public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Benjamin LaHaise <bcrl@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: 2.4.11pre4 and oom
Date: Fri, 5 Oct 2001 14:06:00 +0200	[thread overview]
Message-ID: <20011005140600.G724@athlon.random> (raw)

as far I can tell the oom patch you included in pre4 can deadlock the
machine during oom. Obviously, think if the oom-selected task is looping
trying to free memory, it won't care about the signal you sent to it.
This ignoring the fact it can be in D state and the fact oom() cannot
know know when we're oom or not by only looking at the incomplete stats
anyways.

Now it's obvious you don't care and that most people won't notice the
problem (and the problem is always been in -ac VM too most probably for
ages and again nobody is complaining) and that it is going to cure the
oom faliures and that we could just ignore any seldom oom deadlock
bugreport with Ben's argument that people shouldn't run oom in first
place, but despite of this I prefer not to take that route in -aa
because I strongly believe that people is allowed to run oom without
turning down the machine, infact I also dislike the PF_MEMALLOC logic
that doesn't mathematically "guarantee" that there's enough memory to
"release memory", there should be proper reservation done by each
filesystem that can be involved in the ram freeing (like we do with
highmem), but ok, that's invasive change so I'm living with PF_MEMALLOC
for now, let's assume there's really enough memory in the pf_memalloc
reserved pool.

Andrea

                 reply	other threads:[~2001-10-05 12:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011005140600.G724@athlon.random \
    --to=andrea@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox