From: Richard Henderson <rth@twiddle.net>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 2.4.11-pre5] atomic_dec_and_lock() for alpha
Date: Mon, 8 Oct 2001 10:24:12 -0700 [thread overview]
Message-ID: <20011008102412.A24348@twiddle.net> (raw)
In-Reply-To: <20011008194257.A705@jurassic.park.msu.ru>
In-Reply-To: <20011008194257.A705@jurassic.park.msu.ru>; from ink@jurassic.park.msu.ru on Mon, Oct 08, 2001 at 07:42:57PM +0400
On Mon, Oct 08, 2001 at 07:42:57PM +0400, Ivan Kokshaysky wrote:
> + " ret\n"
I am extremely uncomfortable with you returning out of the middle of
an asm statement. What if the compiler decides to allocate a stack
frame for some reason? You'll return without deallocating it.
Please write the whole thing in assembly or avoid the early return.
r~
next prev parent reply other threads:[~2001-10-08 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-08 15:42 [patch 2.4.11-pre5] atomic_dec_and_lock() for alpha Ivan Kokshaysky
2001-10-08 17:24 ` Richard Henderson [this message]
2001-10-09 10:30 ` Ivan Kokshaysky
2001-10-11 18:28 ` Richard Henderson
2001-10-12 12:35 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011008102412.A24348@twiddle.net \
--to=rth@twiddle.net \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox