From: Andreas Dilger <adilger@turbolabs.com>
To: Martin Wilck <Martin.Wilck@fujitsu-siemens.com>
Cc: Richard Gooch <rgooch@ras.ucalgary.ca>,
Matt Domsch <mdomsch@Dell.com>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EFI GUID Partition Tables
Date: Fri, 12 Oct 2001 10:27:03 -0600 [thread overview]
Message-ID: <20011012102703.Q8382@turbolinux.com> (raw)
In-Reply-To: <200110091725.f99HPZ530405@vindaloo.ras.ucalgary.ca> <Pine.LNX.4.33.0110121026430.9327-100000@biker.pdb.fsc.net>
In-Reply-To: <Pine.LNX.4.33.0110121026430.9327-100000@biker.pdb.fsc.net>
On Oct 12, 2001 10:31 +0200, Martin Wilck wrote:
> Richard,
> > You've put the devfs_unregister_slave() inside an #ifdef. Yuk! It
> > shouldn't be conditional.
>
> I did that because I didn't want to pollute your code. The function
> was only needed for the UUID patch.
What would be more fitting is to put the actual declaration of
devfs_unregister_slave() inside the #ifdef, and otherwise have an
empty function which does nothing.
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
next prev parent reply other threads:[~2001-10-12 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-09 17:15 [PATCH] EFI GUID Partition Tables Matt Domsch
2001-10-09 17:25 ` Richard Gooch
2001-10-12 8:31 ` Martin Wilck
2001-10-12 14:56 ` Richard Gooch
2001-10-12 16:27 ` Andreas Dilger [this message]
2001-10-09 21:03 ` Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2001-10-10 3:01 Matt_Domsch
2001-10-10 4:23 ` Andreas Dilger
2001-10-12 10:12 ` Martin Wilck
2001-10-10 5:18 ` Richard Gooch
2001-10-10 22:08 Matt_Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011012102703.Q8382@turbolinux.com \
--to=adilger@turbolabs.com \
--cc=Martin.Wilck@fujitsu-siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdomsch@Dell.com \
--cc=rgooch@ras.ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox