Re: [PATCH] Oops in usb-storage.c

Matthew Dharm
2001-10-17T06:24:38Z

[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]

Ahh... you've never used cdrecord -scanbus

Technically, as long as the system believes that the target exists (i.e.
you haven't unloaded your SCSI driver module), the target is required to
respond to an INQUIRY command. So, if you boot with the scanner on, and
then turn it off, you've got a problem.

What you say about behavior is correct, but it's just another symptom. If
you run cdrecord -scanbus with a disconnected USB device, it just gives you
garbage, which is bad also.

Matt

On Wed, Oct 17, 2001 at 03:44:10AM +0200, Jan Niehusmann wrote:
> On Tue, Oct 16, 2001 at 06:32:43PM -0700, Matthew Dharm wrote:
> > No, I think something different is best.
> >
> > Your first change to push the US_FL_FIX_INQUIRY code down after the test
> > for pusb_dev is good.. but, in the case where that pointer is bad, we need
> > to cook up something totally fake, like INQUIRY data that says
> > "DISCONNECTED" "USB-STORAGE DEVICE" or somesuch.....
>
> Then I don't understand why we have to answer the INQUIRY at all.
> This could as well be a disconnected / turned off external scsi
> device. I often turn off my external scsi scanner while the system
> is running, without a problem up to now. The scanner surely doesn't
> answer to INQUIRYs when it's turned off...
>
> By the way - a device not needing the US_FL_FIX_INQUIRY code wouldn't
> answer to INQUIRYs either, when it's disconnected. So the patch I sent
> first gives the same behaviour for devices with and without
> US_FL_FIX_INQUIRY set.
>
> Jan
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

E: You run this ship with Windows?! YOU IDIOT!
L: Give me a break, it came bundled with the computer!
-- ESR and Lan Solaris
User Friendly, 12/8/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]