From: Andrea Arcangeli <andrea@suse.de>
To: Chip Salzenberg <chip@pobox.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Maneesh Soni <maneesh@in.ibm.com>
Subject: Re: [PATCH] 2.4.13pre3aa1: expand_fdset() may use invalid pointer
Date: Wed, 17 Oct 2001 20:42:04 +0200 [thread overview]
Message-ID: <20011017204204.C2380@athlon.random> (raw)
In-Reply-To: <20011017113245.A3849@perlsupport.com>
In-Reply-To: <20011017113245.A3849@perlsupport.com>; from chip@pobox.com on Wed, Oct 17, 2001 at 11:32:45AM -0700
On Wed, Oct 17, 2001 at 11:32:45AM -0700, Chip Salzenberg wrote:
> In 2.4.13pre3aa1, expand_fdset() in fs/file.c has a couple of
> execution paths that call kfree() on a pointer that hasn't yet been
> initialized. A minimal patch is attached.
Good spotting! Thanks for the fix!! applied.
CC'ed Maneesh since he's maintaining the rcu_fdset patch AFIK.
> --
> Chip Salzenberg - a.k.a. - <chip@pobox.com>
> "We have no fuel on board, plus or minus 8 kilograms." -- NEAR tech
>
> Index: linux/fs/file.c
> --- linux/fs/file.c.old Tue Oct 16 23:28:16 2001
> +++ linux/fs/file.c Wed Oct 17 00:29:43 2001
> @@ -203,5 +203,5 @@
> fd_set *new_openset = 0, *new_execset = 0;
> int error, nfds = 0;
> - struct rcu_fd_set *arg;
> + struct rcu_fd_set *arg = NULL;
>
> error = -EMFILE;
Andrea
next prev parent reply other threads:[~2001-10-17 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-17 18:32 [PATCH] 2.4.13pre3aa1: expand_fdset() may use invalid pointer Chip Salzenberg
2001-10-17 18:42 ` Andrea Arcangeli [this message]
2001-10-18 6:41 ` Maneesh Soni
2001-10-18 8:22 ` Andrea Arcangeli
2001-10-18 9:48 ` Maneesh Soni
2001-10-18 10:06 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011017204204.C2380@athlon.random \
--to=andrea@suse.de \
--cc=chip@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox