Re: [PATCH] 2.4.13pre3aa1: expand_fdset() may use invalid pointer

Andrea Arcangeli
2001-10-17T18:42:53Z

On Wed, Oct 17, 2001 at 11:32:45AM -0700, Chip Salzenberg wrote:
> In 2.4.13pre3aa1, expand_fdset() in fs/file.c has a couple of
> execution paths that call kfree() on a pointer that hasn't yet been
> initialized. A minimal patch is attached.

Good spotting! Thanks for the fix!! applied.

CC'ed Maneesh since he's maintaining the rcu_fdset patch AFIK.

> --
> Chip Salzenberg - a.k.a. - <chip@pobox.com>
> "We have no fuel on board, plus or minus 8 kilograms." -- NEAR tech

>
> Index: linux/fs/file.c
> --- linux/fs/file.c.old Tue Oct 16 23:28:16 2001
> +++ linux/fs/file.c Wed Oct 17 00:29:43 2001
> @@ -203,5 +203,5 @@
> fd_set *new_openset = 0, *new_execset = 0;
> int error, nfds = 0;
> - struct rcu_fd_set *arg;
> + struct rcu_fd_set *arg = NULL;
>
> error = -EMFILE;

Andrea