possible bug in 2.4.x pc_keyb.c

possible bug in 2.4.x pc_keyb.c

[Walter Harms]

hi list,

keyboard disappears with 2.4.x kernel on notebook (compaq amarda)

After some time the keyboard from my amarda notebook does not respond to anything. The only hint is that 
"keyboard: Timeout - AT keyboard not present?" appears
quit often in the syslog before the kbd stops working.

Comparing the 2.2.x code (no problems) with the 2.4.x code i found pckbd_leds() as prime suspect.
as you can see it sets kbd_exists = 0 (FALSE) after sending an ENABLE. I am not sure if this is my probleme (read: no time to check if this fix works) but i guess its wrong. 

Note: 
1. the error isnt easy reproduceable but appears only with the 2.4.x 
2. send_data returns 1 for  acknowledge  else 0 
3. kann sombody please document kbd_exists ?

	walter



org:

void pckbd_leds(unsigned char leds)
{
        if (kbd_exists && (!send_data(KBD_CMD_SET_LEDS) || !send_data(leds))) {
                send_data(KBD_CMD_ENABLE);      /* re-enable kbd if any errors *
/
                kbd_exists = 0;
        }
}


my idea:

 if () {
	   if (send_data(KBD_CMD_ENABLE)){
        printk(KERN_WARNING "Keyboard off-line ?!\n");
		kbd_exists = FALSE;
		}
	}

Re: possible bug in 2.4.x pc_keyb.c

[Keith Owens]

On Mon, 22 Oct 2001 16:36:25 +0100, 
<WHarms@bfs.de> wrote:
>keyboard disappears with 2.4.x kernel on notebook (compaq amarda)
>
>After some time the keyboard from my amarda notebook does not respond to anything. The only hint is that 
>"keyboard: Timeout - AT keyboard not present?" appears
>quit often in the syslog before the kbd stops working.

Which Armada?  I have been running 2.4.10-pre8-xfs-kdb on a 1598DT
since September 12 with no problems.

Re: possible bug in 2.4.x pc_keyb.c

[Len Sorensen]

On Mon, Oct 22, 2001 at 04:36:25PM +0100, Walter Harms wrote:
> hi list,
> 
> keyboard disappears with 2.4.x kernel on notebook (compaq amarda)
> 
> After some time the keyboard from my amarda notebook does not respond to anything. The only hint is that 
> "keyboard: Timeout - AT keyboard not present?" appears
> quit often in the syslog before the kbd stops working.
> 
> Comparing the 2.2.x code (no problems) with the 2.4.x code i found pckbd_leds() as prime suspect.
> as you can see it sets kbd_exists = 0 (FALSE) after sending an ENABLE. I am not sure if this is my probleme (read: no time to check if this fix works) but i guess its wrong. 
> 
> Note: 
> 1. the error isnt easy reproduceable but appears only with the 2.4.x 
> 2. send_data returns 1 for  acknowledge  else 0 
> 3. kann sombody please document kbd_exists ?

I have seen this error on every 2.4 and 2.3.99 kernel I have used
on every machine I use.  The machiens I have used it on are all IBM
Intelistation or IBM PC300GL machines.  Whenever the keyboard interrupt
it lost, I either loose the character I just typed (most common), or
get a duplicate of the character.  If it happens when I hit shift, the
shift can get stuck since the release is lost.  Same for ALT and CTRL.
It never happened with any 2.2 kernel.  The keyboard always comes back
after loosing the one character (although I think I have had it die for
about 1 second a few times, although not lately).

Len Sorensen

Re: possible bug in 2.4.x pc_keyb.c

[Fabbione]

" (Walter Harms)" wrote:
> 
> hi list,
> 
> keyboard disappears with 2.4.x kernel on notebook (compaq amarda)
> 

Hi,
	Im running kernels from 2.4.2 -> 2.4.9 on an Armada M700
without any problems.

Fabbione

-- 
Debian GNU/Linux Unstable Kernel 2.4.9
fabbione on irc.atdot.it #coredump #kchat | fabbione@fabbione.net