From: Benjamin LaHaise <bcrl@redhat.com>
To: "David S. Miller" <davem@redhat.com>
Cc: sten@blinkenlights.nl, linux-kernel@vger.kernel.org
Subject: Re: INIT_MMAP on sparc64
Date: Mon, 22 Oct 2001 11:14:16 -0400 [thread overview]
Message-ID: <20011022111416.A23213@redhat.com> (raw)
In-Reply-To: <20011021.080432.71105870.davem@redhat.com> <Pine.LNX.4.40-blink.0110211736030.19859-100000@deepthought.blinkenlights.nl> <20011021.181523.112610375.davem@redhat.com>
In-Reply-To: <20011021.181523.112610375.davem@redhat.com>; from davem@redhat.com on Sun, Oct 21, 2001 at 06:15:23PM -0700
On Sun, Oct 21, 2001 at 06:15:23PM -0700, David S. Miller wrote:
>
> DRI works perfectly fine in my current sources, patches below.
On a side note of coding style, the following:
> +#ifdef __sparc__
> + if (io_remap_page_range(vma->vm_start,
> + VM_OFFSET(vma) + offset,
> + vma->vm_end - vma->vm_start,
> + vma->vm_page_prot, 0))
> +#else
> if (remap_page_range(vma->vm_start,
> VM_OFFSET(vma) + offset,
> vma->vm_end - vma->vm_start,
> vma->vm_page_prot))
> +#endif
should really be turned into io_remap_page_range(...) unconditionally
and add a #define for io_remap_page_range in the arch specific code.
Having #ifdef's all over generic code is just ugly.
-ben
next prev parent reply other threads:[~2001-10-22 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-21 15:10 INIT_MMAP on sparc64 Sten
2001-10-21 15:04 ` David S. Miller
2001-10-21 15:52 ` Sten
2001-10-22 1:15 ` David S. Miller
2001-10-22 15:14 ` Benjamin LaHaise [this message]
2001-10-22 22:39 ` Sten
2001-10-22 22:28 ` David S. Miller
2001-10-22 22:50 ` Sten
2001-10-22 22:39 ` David S. Miller
2001-10-22 23:00 ` Sten
2001-10-22 23:23 ` Jeff Garzik
2001-10-22 23:18 ` Mr. James W. Laferriere
2001-10-22 23:24 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011022111416.A23213@redhat.com \
--to=bcrl@redhat.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sten@blinkenlights.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox