From: Christoph Hellwig <hch@caldera.de>
To: Alexander Viro <viro@math.psu.edu>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [CFT][PATCH] cdrom-related rmmod races
Date: Tue, 23 Oct 2001 15:42:18 +0200 [thread overview]
Message-ID: <20011023154218.A14829@caldera.de> (raw)
In-Reply-To: <200110231057.f9NAvGI31569@ns.caldera.de> <Pine.GSO.4.21.0110230713140.7440-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0110230713140.7440-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Tue, Oct 23, 2001 at 07:14:27AM -0400
On Tue, Oct 23, 2001 at 07:14:27AM -0400, Alexander Viro wrote:
>
>
> On Tue, 23 Oct 2001, Christoph Hellwig wrote:
>
> > Wouldn't it be easier to add a 'struct module *owner' to struct
> > block_device_operations?
>
> All of them share (in the current tree) block_device_operations -
> cdrom_fops from drivers/cdrom/cdrom.c. What will you put as
> ->owner there?
Of course they would have to have their own block_device_operations as
well - but they could continue to use the common open method.
Also this would allow to get rid of the MOD_{INC,DEC}_USE_COUNT in the
blockdrivers and thus make it easier for driver writers to create races.
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
prev parent reply other threads:[~2001-10-23 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-23 10:45 [CFT][PATCH] cdrom-related rmmod races Alexander Viro
2001-10-23 10:57 ` Christoph Hellwig
2001-10-23 11:14 ` Alexander Viro
2001-10-23 13:42 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011023154218.A14829@caldera.de \
--to=hch@caldera.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox