The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: baggins@sith.mimuw.edu.pl
Cc: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org,
	torvalds@transmeta.com
Subject: [PATCH] Acenic fix (was Re: acenic breakage in 2.4.13-pre)
Date: Wed, 24 Oct 2001 13:10:14 -0700 (PDT)	[thread overview]
Message-ID: <20011024.131014.59653371.davem@redhat.com> (raw)
In-Reply-To: <20011024180414.A16921@sith.mimuw.edu.pl>
In-Reply-To: <20011024.082925.68578636.davem@redhat.com> <20011024180414.A16921@sith.mimuw.edu.pl>

   From: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
   Date: Wed, 24 Oct 2001 18:04:14 +0200

   On Wed, 24 Oct 2001, David S. Miller wrote:
   
   >    From: Jan Rekorajski <baggins@sith.mimuw.edu.pl>
   >    Date: Wed, 24 Oct 2001 16:45:33 +0200
   >    
   >    Speaking of acenic - it's broken in 2.4.13-pre. I have 3c985 and all I
   >    get with 2.4.13-pre is "Firmware NOT running!". After I backed the
   >    changes from -pre patch it started and works fine. Maybe the problem is
   >    I have it in 32bit PCI slot?
   > 
   > Do you have CONFIG_HIGHMEM enabled?  If so, please try with
   > it turned off.
   
   Nope. No HIGHMEM here.

The patch below should cure the problem.

Linus, please apply.

diff -u --recursive --new-file --exclude=CVS --exclude=.cvsignore vanilla/linux/drivers/net/acenic.c linux/drivers/net/acenic.c
--- vanilla/linux/drivers/net/acenic.c	Fri Oct 12 15:35:53 2001
+++ linux/drivers/net/acenic.c	Wed Oct 24 08:32:43 2001
@@ -1051,7 +1051,8 @@
 	struct ace_private *ap;
 	struct ace_regs *regs;
 	struct ace_info *info = NULL;
-	unsigned long tmp_ptr, myjif;
+	u64 tmp_ptr;
+	unsigned long myjif;
 	u32 tig_ver, mac1, mac2, tmp, pci_state;
 	int board_idx, ecode = 0;
 	short i;

  parent reply	other threads:[~2001-10-24 20:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-24 14:45 acenic breakage in 2.4.13-pre Jan Rekorajski
2001-10-24 14:56 ` Jeff Garzik
2001-10-24 15:24   ` David S. Miller
2001-10-24 15:29 ` David S. Miller
2001-10-24 16:04   ` Jan Rekorajski
2001-10-24 16:36     ` David S. Miller
2001-10-24 18:49       ` Jan Rekorajski
2001-10-24 19:14         ` J Sloan
2001-10-24 20:10     ` David S. Miller [this message]
2001-10-24 15:40 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011024.131014.59653371.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=baggins@sith.mimuw.edu.pl \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox