From: Vojtech Pavlik <vojtech@suse.cz>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alan Cox <laughing@shared-source.org>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.13-ac4
Date: Mon, 29 Oct 2001 18:48:05 +0100 [thread overview]
Message-ID: <20011029184805.A4504@suse.cz> (raw)
In-Reply-To: <20011029084736.A3152@suse.cz> <E15yA5r-0002Ha-00@the-village.bc.nu>
In-Reply-To: <E15yA5r-0002Ha-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Mon, Oct 29, 2001 at 10:56:35AM +0000
On Mon, Oct 29, 2001 at 10:56:35AM +0000, Alan Cox wrote:
> > bytes read from the 8254 get swapped. I've got some indirect evidence
> > that this also could happen with the original i8254.
>
> Im hoping not. That would imply we interrupted someone half way through
> reading the counter which means the locking is screwed up.
>
> > By the way, if we made the 8254 accesses (spinlock?) protected (which
> > should be done anyway, right now definitely more than one CPU can access
> > the registers at once), I think we could remove the outb(0, 0x43);,
> > saving some cycles.
>
> Some chipsets need the outb
I'm looking at how to cleanly fix the timer accesses. And I think a
common inline function that does the
lock
outb
inb
inb
check - via, other bugs
unlock
would make sense. What do you think?
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2001-10-29 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-28 20:40 Linux 2.4.13-ac4 Alan Cox
2001-10-29 7:47 ` Vojtech Pavlik
2001-10-29 10:56 ` Alan Cox
2001-10-29 16:38 ` Vojtech Pavlik
2001-10-29 17:14 ` Henning P. Schmiedehausen
2001-10-29 17:28 ` Maciej W. Rozycki
2001-10-29 17:48 ` Vojtech Pavlik [this message]
2001-10-29 16:07 ` Maciej W. Rozycki
2001-10-29 16:19 ` Alan Cox
2001-10-29 20:03 ` Vojtech Pavlik
2001-10-30 11:23 ` Maciej W. Rozycki
2001-10-30 4:09 ` George Garvey
2001-10-30 4:24 ` Mike Fedyk
[not found] <E15yFhL-0003ED-00@the-village.bc.nu>
2001-10-29 17:11 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011029184805.A4504@suse.cz \
--to=vojtech@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=laughing@shared-source.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox