From: Robert Kuebel <kuebelr@email.uc.edu>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 8139too termination
Date: Mon, 29 Oct 2001 19:08:17 -0500 [thread overview]
Message-ID: <20011029190817.B320@cartman> (raw)
In-Reply-To: <20011029181029.A320@cartman> <3BDDE5DF.71917D8F@zip.com.au>
In-Reply-To: <3BDDE5DF.71917D8F@zip.com.au>
>
> tp->diediedie = 1;
> wmb();
> ret = kill_proc(...);
>
> and test the flag in rtl8139_thread().
>
i had something like that in mind.
> The tricky part is teaching the thread to ignore the
> spurious signals - the signal_pending() state needs to be
> cleared. I think flush_signals() is the way to do this.
> See context_thread() for an example.
>
> spin_lock_irq(&curtask->sigmask_lock);
> flush_signals(curtask);
> recalc_sigpending(curtask);
> spin_unlock_irq(&curtask->sigmask_lock);
>
> The recalc_sigpending() here appears to be unnecessary...
>
what about changing doing
spin_lock_irq(¤t->sigmask_lock);
sigfillset(¤t->blocked); /* block all sig's */
recalc_sigpending(current);
spin_unlock_irq(¤t->sigmask_lock);
instead of
spin_lock_irq(¤t->sigmask_lock);
sigemptyset(¤t->blocked);
recalc_sigpending(current);
spin_unlock_irq(¤t->sigmask_lock);
and replacing the signal_pending() stuff in the loops of
rtl8139_thread() with checks for tp->diediedie?
next prev parent reply other threads:[~2001-10-30 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-29 23:10 8139too termination Robert Kuebel
2001-10-29 23:27 ` Andrew Morton
2001-10-30 0:08 ` Robert Kuebel [this message]
[not found] ` <3BDDF4B0.194E132F@zip.com.au>
2001-10-30 0:58 ` Robert Kuebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011029190817.B320@cartman \
--to=kuebelr@email.uc.edu \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox