public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Kuebel <kuebelr@email.uc.edu>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 8139too termination
Date: Mon, 29 Oct 2001 19:58:58 -0500	[thread overview]
Message-ID: <20011029195858.A649@cartman> (raw)
In-Reply-To: <20011029181029.A320@cartman> <3BDDE5DF.71917D8F@zip.com.au>, <3BDDE5DF.71917D8F@zip.com.au> <20011029190817.B320@cartman> <3BDDF4B0.194E132F@zip.com.au>
In-Reply-To: <3BDDF4B0.194E132F@zip.com.au>

On Mon, Oct 29, 2001 at 04:30:40PM -0800, Andrew Morton wrote:
> Robert Kuebel wrote:
> > 
> > what about changing doing
> >         spin_lock_irq(&current->sigmask_lock);
> >         sigfillset(&current->blocked);  /* block all sig's */
> >         recalc_sigpending(current);
> >         spin_unlock_irq(&current->sigmask_lock);
> > 
> > instead of
> > 
> >         spin_lock_irq(&current->sigmask_lock);
> >         sigemptyset(&current->blocked);
> >         recalc_sigpending(current);
> >         spin_unlock_irq(&current->sigmask_lock);
> > 
> > and replacing the signal_pending() stuff in the loops of
> > rtl8139_thread() with checks for tp->diediedie?
> 
> If you block all the signals then the kill_proc() won't
> bring the thread out of interruptible sleep?

right, you would have to take out the kill_proc().
can't you just let the thread return and not use kill_proc()?  i have
been checking out the reiserfsd thread.

i could be missing something.


      parent reply	other threads:[~2001-10-30  0:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-29 23:10 8139too termination Robert Kuebel
2001-10-29 23:27 ` Andrew Morton
2001-10-30  0:08   ` Robert Kuebel
     [not found]     ` <3BDDF4B0.194E132F@zip.com.au>
2001-10-30  0:58       ` Robert Kuebel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011029195858.A649@cartman \
    --to=kuebelr@email.uc.edu \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox