From: Arjan van de Ven <arjanv@redhat.com>
To: Christoph Hellwig <hch@caldera.de>,
Mike Jagdis <jaggy@purplet.demon.co.uk>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, arjanv@redhat.com
Subject: Re: [PATCH] syscall exports - against 2.4.14-pre3
Date: Tue, 30 Oct 2001 05:44:32 -0500 [thread overview]
Message-ID: <20011030054432.B28368@devserv.devel.redhat.com> (raw)
In-Reply-To: <20011029173711.B24272@caldera.de> <3BDE7D22.8000006@purplet.demon.co.uk> <20011030113731.A14808@caldera.de>
In-Reply-To: <20011030113731.A14808@caldera.de>; from hch@caldera.de on Tue, Oct 30, 2001 at 11:37:31AM +0100
On Tue, Oct 30, 2001 at 11:37:31AM +0100, Christoph Hellwig wrote:
> On Tue, Oct 30, 2001 at 10:12:50AM +0000, Mike Jagdis wrote:
> > > once again the syscall export patch - back to EXPORT_SYMBOL
> "Because we did it all the time it's right".
>
> Of course it worked - that doesn't mean it's a good idea.
> Arjan might want to comment on how gcc 2.96+ liked the old concept..
gcc 2.96 and 3.0 _rightfully_ object to calling a function pointer with a
different number of arguments than the function pointer prototype is. Even
if gcc didn't object to it, I consider it butt-ugly and you also just lost
any and all type checking the compiler can help you with. During the change
to calling the real functions instead of the basicaly untyped function
pointers, quite a few ibcs bugs were fixed just because the arguments were
wrong. I'm with Christoph on this 100%.
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2001-10-30 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-29 16:37 [PATCH] syscall exports - against 2.4.14-pre3 Christoph Hellwig
2001-10-30 10:12 ` Mike Jagdis
2001-10-30 10:37 ` Christoph Hellwig
2001-10-30 10:44 ` Arjan van de Ven [this message]
2001-10-30 15:15 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011030054432.B28368@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=hch@caldera.de \
--cc=jaggy@purplet.demon.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox