From: Jens Axboe <axboe@suse.de>
To: Dan Maas <dmaas@dcine.com>
Cc: "David S. Miller" <davem@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: SCSI tape crashes (was Re: BUG() in asm/pci.h:142 with 2.4.13)
Date: Wed, 31 Oct 2001 09:33:53 +0100 [thread overview]
Message-ID: <20011031093353.F631@suse.de> (raw)
In-Reply-To: <fa.cdhetrv.1828dgd@ifi.uio.no> <fa.j17q3gv.m6e1ju@ifi.uio.no> <022401c16164$21a945d0$1a01a8c0@allyourbase>
In-Reply-To: <022401c16164$21a945d0$1a01a8c0@allyourbase>
On Tue, Oct 30 2001, Dan Maas wrote:
> > Can people try out this patch? I believe this will fix the bug.
> > + tb->sg[0].page = NULL;
> > if (tb->sg[segs].address == NULL) {
>
> For the sake of making this clear to other kernel hackers (I got bitten by
> it too) - starting with 2.4.13 you must zero out the fields of struct
> scatterlist that you are not using. i.e. it is no longer sufficient to
> simply set sg.address and sg.length, because junk might still be present in
> the new sg.page field, and pci_map_*() will BUG() if both sg.address and
> sg.page are non-zero.
True, perhaps we should add a init_sg or something like that.
--
Jens Axboe
next prev parent reply other threads:[~2001-10-31 8:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.cdhetrv.1828dgd@ifi.uio.no>
[not found] ` <fa.j17q3gv.m6e1ju@ifi.uio.no>
2001-10-30 16:58 ` SCSI tape crashes (was Re: BUG() in asm/pci.h:142 with 2.4.13) Dan Maas
2001-10-31 8:33 ` Jens Axboe [this message]
[not found] ` <20011031.004311.85410732.davem@redhat.com>
[not found] ` <20011031094650.H631@suse.de>
2001-10-31 8:49 ` SCSI tape crashes David S. Miller
2001-10-31 8:53 ` Jens Axboe
2001-10-25 11:11 BUG() in asm/pci.h:142 with 2.4.13 Jens Axboe
2001-10-25 17:23 ` Christian Hammers
2001-10-25 17:32 ` Jens Axboe
2001-10-26 0:25 ` SCSI tape crashes (was Re: BUG() in asm/pci.h:142 with 2.4.13) David S. Miller
2001-10-26 2:26 ` Jeff V. Merkey
2001-10-26 1:33 ` Christian Hammers
2001-10-28 1:34 ` Pete Harlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011031093353.F631@suse.de \
--to=axboe@suse.de \
--cc=davem@redhat.com \
--cc=dmaas@dcine.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox