From: Neil Spring <nspring@saavie.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TCP ECN bits and TCP_RESERVED_BITS macro
Date: Wed, 31 Oct 2001 18:53:59 -0800 [thread overview]
Message-ID: <20011031185358.A997@cs.washington.edu> (raw)
In-Reply-To: <20011031152717.A25584@morinfr.org> <20011031154305.A11081@cs.washington.edu> <20011101033221.A627@morinfr.org>
In-Reply-To: <20011101033221.A627@morinfr.org>
> Dans un message du 31 oct ? 15:43, Neil Spring ?crivait :
> > The line in your patch:
> > > -#define TCP_HP_BITS (~(TCP_RESERVED_BITS|TCP_FLAG_PSH)|TCP_FLAG_ECE|TCP_FLAG_CWR)
> > > +#define TCP_HP_BITS (~(TCP_RESERVED_BITS|TCP_FLAG_PSH))
> >
> > is, I believe, a very bad idea. This preprocessor constant
>
> Well it is not.
You're absolutely right. And it is more clean, even if
it confused me at first. Thanks for the explanation.
-neil
nethack told me to be careful, full moon tonight, but I
didn't listen.
prev parent reply other threads:[~2001-11-01 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-31 14:27 [PATCH] TCP ECN bits and TCP_RESERVED_BITS macro Guillaume Morin
2001-10-31 23:43 ` Neil Spring
2001-11-01 2:32 ` Guillaume Morin
2001-11-01 2:53 ` Neil Spring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011031185358.A997@cs.washington.edu \
--to=nspring@saavie.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox