public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: kuznet@ms2.inr.ac.ru
Cc: Andi Kleen <ak@suse.de>,
	joris@deadlock.et.tudelft.nl, linux-kernel@vger.kernel.org
Subject: Re: Bind to protocol with AF_PACKET doesn't work for outgoing packets
Date: Thu, 1 Nov 2001 19:21:53 +0100	[thread overview]
Message-ID: <20011101192153.A30903@wotan.suse.de> (raw)
In-Reply-To: <20011101184511.A22234@wotan.suse.de> <200111011809.VAA26876@ms2.inr.ac.ru>
In-Reply-To: <200111011809.VAA26876@ms2.inr.ac.ru>; from kuznet@ms2.inr.ac.ru on Thu, Nov 01, 2001 at 09:09:07PM +0300

On Thu, Nov 01, 2001 at 09:09:07PM +0300, A.N.Kuznetsov wrote:
> > ugly imho; if the feature exists it should be implemented for the full
> > packet functionality which includes binding to protocols.
> 
> This is a silly abuse. Sniffers do not bind to protocols, should not
> do this and have no reasons to do this.

When you e.g. have a TCP sniffer it makes sense to only bind it to ETH_P_IP.

If the sll_protocol field is not fully supported it should be removed.

> 
> 
> >  I think the patch should be added.
> 
> That which adds all the packet sockets to ptype_all? Do you jest? :-)

Do you worry about the handling of hundreds of packet sockets? 

Using the ptype hash before was nice, but does not look like it is absolutely
required. The overhead this way is not much bigger for a reasonable number
of packet sockets (and for a large number the current ptype hash is likely 
inadequate anyways) 


-Andi

  reply	other threads:[~2001-11-01 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.21.0111010944050.16656-100000@deadlock.et.tudelft.nl.suse.lists.linux.kernel>
2001-11-01 14:30 ` Bind to protocol with AF_PACKET doesn't work for outgoing packets Andi Kleen
2001-11-01 15:18   ` Joris van Rantwijk
2001-11-01 16:46     ` Andi Kleen
2001-11-01 17:33   ` kuznet
2001-11-01 17:45     ` Andi Kleen
2001-11-01 18:09       ` kuznet
2001-11-01 18:21         ` Andi Kleen [this message]
2001-11-01 18:56           ` kuznet
2001-11-01 19:28             ` Andi Kleen
2001-11-01 19:48               ` kuznet
2001-11-01  9:11 Joris van Rantwijk
2001-11-02  2:26 ` Edgar Toernig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011101192153.A30903@wotan.suse.de \
    --to=ak@suse.de \
    --cc=joris@deadlock.et.tudelft.nl \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox