public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan von Krawczynski <skraw@ithnet.com>
To: linux-kernel@vger.kernel.org
Cc: groudier@club-internet.fr
Subject: Adaptec vs Symbios performance
Date: Sat, 03 Nov 2001 23:53:09 +0100	[thread overview]
Message-ID: <200111032253.XAA20342@webserver.ithnet.com> (raw)
In-Reply-To: <3BE3215A.9000302@google.com>

Hello Justin, hello Gerard                                            
                                                                      
I am looking currently for reasons for bad behaviour of aic7xxx driver
in an shared interrupt setup and general not-nice behaviour of the    
driver regarding multi-tasking environment.                           
Here is what I found in the code:                                     
                                                                      
/*                                                                    
 * SCSI controller interrupt handler.                                 
 */                                                                   
void                                                                  
ahc_linux_isr(int irq, void *dev_id, struct pt_regs * regs)           
{                                                                     
        struct ahc_softc *ahc;                                        
        struct ahc_cmd *acmd;                                         
        u_long flags;                                                 
                                                                      
        ahc = (struct ahc_softc *) dev_id;                            
        ahc_lock(ahc, &flags);                                        
        ahc_intr(ahc);                                                
        /*                                                            
         * It would be nice to run the device queues from a           
         * bottom half handler, but as there is no way to             
         * dynamically register one, we'll have to postpone           
         * that until we get integrated into the kernel.              
         */                                                           
        ahc_linux_run_device_queues(ahc);                             
        acmd = TAILQ_FIRST(&ahc->platform_data->completeq);           
        TAILQ_INIT(&ahc->platform_data->completeq);                   
        ahc_unlock(ahc, &flags);                                      
        if (acmd != NULL)                                             
                ahc_linux_run_complete_queue(ahc, acmd);              
}                                                                     
                                                                      
This is nice. I cannot read the complete code around it (it is derived
from aic7xxx_linux.c) but if I understand the naming and comments     
correct, some workload is done inside the hardware interrupt (which   
shouldn't), which would very much match my tests showing bad overall  
performance behaviour. Obviously this code is old (read the comment)  
and needs reworking.                                                  
Comments?                                                             
                                                                      
Regards,                                                              
Stephan                                                               
                                                                      

  parent reply	other threads:[~2001-11-03 22:53 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-31 18:06 Google's mm problem - not reproduced on 2.4.13 Daniel Phillips
2001-10-31 20:39 ` Daniel Phillips
2001-10-31 20:45   ` Andrea Arcangeli
2001-10-31 21:03     ` Daniel Phillips
2001-10-31 21:53       ` Andreas Dilger
2001-11-01  4:52         ` Daniel Phillips
2001-11-01 16:56           ` undefined reference in 2.2.19 build with Reiserfs (was: Google's mm problem - not reproduced on 2.4.13) Sven Heinicke
2001-11-01 22:39             ` Keith Owens
2001-10-31 22:12       ` Google's mm problem - not reproduced on 2.4.13 Ben Smith
2001-11-01  0:34         ` Andrea Arcangeli
2001-11-02 17:51         ` Sven Heinicke
2001-11-02 18:00           ` Andrea Arcangeli
2001-11-02 18:19             ` Daniel Phillips
2001-11-02 20:27               ` Linus Torvalds
2001-11-02 21:08                 ` Ben Smith
2001-11-02 21:20                   ` Linus Torvalds
2001-11-02 22:42                     ` Ben Smith
2001-11-02 23:15                       ` Daniel Phillips
2001-11-03 22:53                       ` Stephan von Krawczynski [this message]
2001-11-03 23:01                         ` Adaptec vs Symbios performance arjan
2001-11-02 21:12                 ` Google's mm problem - not reproduced on 2.4.13 Rik van Riel
     [not found]               ` <200111022027.fA2KRwe20006@penguin.transmeta.com>
2001-11-02 20:58                 ` Daniel Phillips
2001-11-02 18:11           ` Daniel Phillips
2001-11-02 18:48             ` Sven Heinicke
2001-11-02 18:57               ` Daniel Phillips
2001-11-01  0:19     ` Daniel Phillips
2001-11-01  0:29       ` Andrea Arcangeli
2001-11-01  1:17       ` Ben Smith
2001-11-01  1:41         ` Rik van Riel
2001-11-01  1:55           ` Ben Smith
2001-11-01  2:06             ` Andrea Arcangeli
2001-10-31 20:48   ` Rik van Riel
2001-10-31 21:04     ` Daniel Phillips
2001-10-31 21:08       ` Rik van Riel
     [not found] <200111032318.fA3NIQY62745@aslan.scsiguy.com>
2001-11-04  3:50 ` Adaptec vs Symbios performance Stephan von Krawczynski
2001-11-04  5:47   ` Justin T. Gibbs
2001-11-04  5:23     ` Gérard Roudier
2001-11-04 14:17     ` Stephan von Krawczynski
2001-11-04 18:10       ` Justin T. Gibbs
2001-11-04 18:35         ` Stephan von Krawczynski
2001-11-04 16:31           ` Gérard Roudier
2001-11-04 19:13           ` Justin T. Gibbs
2001-11-04 19:56             ` Stephan von Krawczynski
2001-11-04 20:43               ` Justin T. Gibbs
2001-11-05 12:18                 ` Matthias Andree
2001-11-04 19:02         ` Stephan von Krawczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111032253.XAA20342@webserver.ithnet.com \
    --to=skraw@ithnet.com \
    --cc=groudier@club-internet.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox