public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Fedyk <mfedyk@matchmail.com>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@transmeta.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [patch] scheduler cache affinity improvement for 2.4 kernels
Date: Thu, 8 Nov 2001 15:37:49 -0800	[thread overview]
Message-ID: <20011108153749.A14468@mikef-linux.matchmail.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0111082028430.20248-100000@localhost.localdomain> <Pine.LNX.4.40.0111081056490.1501-100000@blue1.dev.mcafeelabs.com>
In-Reply-To: <Pine.LNX.4.40.0111081056490.1501-100000@blue1.dev.mcafeelabs.com>

On Thu, Nov 08, 2001 at 11:13:30AM -0800, Davide Libenzi wrote:
> On Thu, 8 Nov 2001, Ingo Molnar wrote:
> 
> >
> > On Thu, 8 Nov 2001, Davide Libenzi wrote:
> >
> > > It sets the time ( in jiffies ) at which the process won't have any
> > > more scheduling advantage.
> >
> > (sorry, it indeed makes sense, since sched_jtime is on the order of
> > jiffies.)
> >
> > > > and your patch adds a scheduling advantage to processes with more cache
> > > > footprint, which is the completely opposite of what we want.
> > >
> > > It is exactly what we want indeed :
> >
> > if this is what is done by your patch, then we do not want to do this.
> > My patch does not give an advantage of CPU-intensive processes over that
> > of eg. 'vi'.
> 
> If A & B are CPU hog processes and E is the editor ( low level keventd )
> you do want to avoid priority inversion between A and B when E kicks in.
> Really IO bound tasks accumulates dynamic priority inside the recalc loop
> and this is sufficent to win over this kind of "advantage" given to CPU
> hog tasks.
> My approach make also more "expensive" the preemption goodness to move
> tasks between CPUs.
> I'll take a closer look at your patch anyway.
> 

Conceptually, both patches are compatible.

Whether they are technically is for someone else to say...

Ingo's patch in effect lowers the number of jiffies taken per second in the
scheduler (by making each task use several jiffies).

Davide's patch can take the default scheduler (even Ingo's enhanced
scheduler) and make it per processor, with his extra layer of scheduling
between individual processors.

I think that together, they both win.  Davide's patch keeps a task from
switching CPUs very often, and Ingo's patch will make each task on each CPU
use the cache to the best extent for that task.

It remains to be proven whether the coarser scheduling approach (Ingo's) will
actually help when looking at cache properties....  When each task takes a
longer time slice, that allows the other tasks to be flushed out of the
caches during that time.  When the next task comes back in, it will have to
re-populate the cache again.  And the same for the next and etc...

Mike

  reply	other threads:[~2001-11-08 23:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-08 14:30 [patch] scheduler cache affinity improvement for 2.4 kernels Ingo Molnar
2001-11-08 15:22 ` M. Edward Borasky
2001-11-08 16:33   ` Ingo Molnar
2001-11-08 17:15 ` Davide Libenzi
2001-11-08 18:27   ` Ingo Molnar
2001-11-08 18:03     ` Davide Libenzi
2001-11-08 19:40       ` Ingo Molnar
2001-11-08 19:13         ` Davide Libenzi
2001-11-08 23:37           ` Mike Fedyk [this message]
2001-11-09  0:37             ` Davide Libenzi
2001-11-09  1:07               ` Mike Fedyk
2001-11-09  1:29                 ` Davide Libenzi
2001-11-09  1:34                   ` Mike Fedyk
2001-11-09  2:09                     ` Davide Libenzi
2001-11-09  2:08                       ` Mike Fedyk
2001-11-19 18:34               ` bill davidsen
2001-11-09  8:28             ` Ingo Molnar
2001-11-09  8:05               ` Mike Fedyk
2001-11-11 21:18               ` Davide Libenzi
2001-11-11 22:31                 ` Davide Libenzi
2001-11-08 23:46 ` Andrea Arcangeli
2001-11-09  0:31 ` Davide Libenzi
2001-11-14  4:56 ` Mike Kravetz
2001-11-14 18:08   ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011108153749.A14468@mikef-linux.matchmail.com \
    --to=mfedyk@matchmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox