From: Christoph Hellwig <hch@caldera.de>
To: Mingming cao <cmm@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
lse-tech@lists.sourceforge.net
Subject: Re: [Lse-tech] [PATCH]Disk IO statisitics gathering for all disks
Date: Thu, 8 Nov 2001 23:39:12 +0100 [thread overview]
Message-ID: <20011108233912.A5845@caldera.de> (raw)
In-Reply-To: <3BEB0848.735652EF@us.ibm.com>
In-Reply-To: <3BEB0848.735652EF@us.ibm.com>; from cmm@us.ibm.com on Thu, Nov 08, 2001 at 02:33:44PM -0800
On Thu, Nov 08, 2001 at 02:33:44PM -0800, Mingming cao wrote:
> Hello,
>
> Attached is a patch to dynamically allocate the data buffers for the
> disk statistics, and to extend the gathering of disk statistics to
> include major numbers greater than 15.
>
> A disk statistics structure is allocated when a new block device
> is registered. A global array (kstat.dkdrive_info[]) is used
> to hold the address of the statistics structures for all block
> devices. The disk statistics lookup is the same as before: indexed by
> the major number and the disk number.
A very minor nitpick: please use struct dk_stat (or disk_stat) instead of
dk_stat_t - it is by no means an opaque type.
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
next prev parent reply other threads:[~2001-11-08 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-08 22:33 [PATCH]Disk IO statisitics gathering for all disks Mingming cao
2001-11-08 22:39 ` Christoph Hellwig [this message]
2001-11-09 0:45 ` [Lse-tech] " Mingming cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011108233912.A5845@caldera.de \
--to=hch@caldera.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cmm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox