From: Jens Axboe <axboe@suse.de>
To: "Ronny Lampert (EED)" <Ronny.Lampert@eed.ericsson.se>
Subject: Re: 2.4.14: crashing on heavy swap-load with SmartArray (dmesg/.config output)
Date: Fri, 9 Nov 2001 14:37:20 +0100 [thread overview]
Message-ID: <20011109143720.T4946@suse.de> (raw)
In-Reply-To: <3BEBD6E9.3F7F8057@eed.ericsson.se>
In-Reply-To: <3BEBD6E9.3F7F8057@eed.ericsson.se>
[-- Attachment #1: Type: text/plain, Size: 137 bytes --]
On Fri, Nov 09 2001, Ronny Lampert (EED) wrote:
[smart array crashing]
Apply this on top of 2.4.14 and you'll be fine.
--
Jens Axboe
[-- Attachment #2: cpq-dequeue-1 --]
[-- Type: text/plain, Size: 724 bytes --]
--- linux/drivers/block/cpqarray.c~ Thu Nov 8 11:33:11 2001
+++ linux/drivers/block/cpqarray.c Thu Nov 8 11:35:31 2001
@@ -942,6 +942,8 @@
if ((c = cmd_alloc(h,1)) == NULL)
goto startio;
+ blkdev_dequeue_request(creq);
+
spin_unlock_irq(&io_request_lock);
bh = creq->bh;
@@ -987,13 +989,10 @@
DBGPX( printk("Submitting %d sectors in %d segments\n", sect, seg); );
c->req.hdr.sg_cnt = seg;
c->req.hdr.blk_cnt = creq->nr_sectors;
-
- spin_lock_irq(&io_request_lock);
-
- blkdev_dequeue_request(creq);
-
c->req.hdr.cmd = (creq->cmd == READ) ? IDA_READ : IDA_WRITE;
c->type = CMD_RWREQ;
+
+ spin_lock_irq(&io_request_lock);
/* Put the request on the tail of the request queue */
addQ(&h->reqQ, c);
next prev parent reply other threads:[~2001-11-09 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-09 13:15 2.4.14: crashing on heavy swap-load with SmartArray (dmesg/.config output) Ronny Lampert (EED)
2001-11-09 13:37 ` Jens Axboe [this message]
2001-11-09 14:44 ` 2.4.14: crashing on heavy swap-load with SmartArray (cont.) Ronny Lampert (EED)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011109143720.T4946@suse.de \
--to=axboe@suse.de \
--cc=Ronny.Lampert@eed.ericsson.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox