Re: [PATCH] fix loop with disabled tasklets

David S. Miller
2001-11-12T07:59:44Z

From: Mathijs Mohlmann <mathijs@knoware.nl>
Date: Mon, 12 Nov 2001 08:42:27 +0100 (CET)

Even if the timer irq is working fine, the sun should not enable the
keyboard irq without the tasklet being enabled. Initializing the keyboard
tasklet enabled got the sun to boot just fine for me.

They come from the serial port, not from a normal "IRQ".
This is why events arrive so early.

Linus's proposed solution will work just fine and frankly
that's what I'm going to check into my tree. :-) For
reference this is:

1) Kill DECLARE_TASKLET_DISABLED use DECLARE_TASKLET for
keyboard_tasklet.

2) In keyboard tasklet handler check a "keyboard_init_done"
boolean and just return immediately if it is clear.

3) Where we currently do "tasklet_enable(&keyboard_tasklet);"
simply kill that line and check it to
"keyboard_init_done = 1;"

Franks a lot,
David S. Miller
davem@redhat.com