From: "David S. Miller" <davem@redhat.com>
To: mathijs@knoware.nl
Cc: andrea@suse.de, jgarzik@mandrakesoft.com,
linux-kernel@vger.kernel.org, torvalds@transmeta.com,
kuznet@ms2.inr.ac.ru
Subject: Re: [PATCH] fix loop with disabled tasklets
Date: Sun, 11 Nov 2001 23:59:05 -0800 (PST) [thread overview]
Message-ID: <20011111.235905.28785376.davem@redhat.com> (raw)
In-Reply-To: <Pine.BSI.4.05L.10111120819290.9564-100000@utopia.knoware.nl>
In-Reply-To: <20011112021142.O1381@athlon.random> <Pine.BSI.4.05L.10111120819290.9564-100000@utopia.knoware.nl>
From: Mathijs Mohlmann <mathijs@knoware.nl>
Date: Mon, 12 Nov 2001 08:42:27 +0100 (CET)
Even if the timer irq is working fine, the sun should not enable the
keyboard irq without the tasklet being enabled. Initializing the keyboard
tasklet enabled got the sun to boot just fine for me.
They come from the serial port, not from a normal "IRQ".
This is why events arrive so early.
Linus's proposed solution will work just fine and frankly
that's what I'm going to check into my tree. :-) For
reference this is:
1) Kill DECLARE_TASKLET_DISABLED use DECLARE_TASKLET for
keyboard_tasklet.
2) In keyboard tasklet handler check a "keyboard_init_done"
boolean and just return immediately if it is clear.
3) Where we currently do "tasklet_enable(&keyboard_tasklet);"
simply kill that line and check it to
"keyboard_init_done = 1;"
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-11-12 7:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-10 12:21 [PATCH] fix loop with disabled tasklets Mathijs Mohlmann
2001-11-10 13:37 ` David S. Miller
2001-11-10 15:03 ` Andrea Arcangeli
2001-11-10 15:29 ` Mathijs Mohlmann
2001-11-10 16:02 ` Alan Cox
2001-11-10 16:37 ` Andrea Arcangeli
2001-11-12 1:11 ` Andrea Arcangeli
2001-11-12 7:42 ` Mathijs Mohlmann
2001-11-12 7:59 ` David S. Miller [this message]
2001-11-12 14:03 ` Andrea Arcangeli
2001-11-12 13:57 ` Andrea Arcangeli
2001-11-12 8:03 ` David S. Miller
2001-11-12 14:04 ` Andrea Arcangeli
2001-11-12 14:20 ` Andrea Arcangeli
2001-11-12 17:10 ` Thorsten Kukuk
2001-11-12 19:03 ` Mathijs Mohlmann
2001-11-11 2:32 ` Mathijs Mohlmann
-- strict thread matches above, loose matches on Subject: below --
2001-11-11 15:56 Momchil Velikov
2001-11-12 7:46 ` Mathijs Mohlmann
2001-11-12 8:00 ` David S. Miller
2001-11-12 8:07 ` Momchil Velikov
2001-11-12 9:11 ` Mathijs Mohlmann
2001-11-12 9:41 ` Momchil Velikov
2001-11-12 9:54 ` Mathijs Mohlmann
2001-11-12 15:33 Petr Vandrovec
2001-11-12 14:48 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011111.235905.28785376.davem@redhat.com \
--to=davem@redhat.com \
--cc=andrea@suse.de \
--cc=jgarzik@mandrakesoft.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mathijs@knoware.nl \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox