From: "David S. Miller" <davem@redhat.com>
To: tip@internetwork-ag.de
Cc: linux-kernel@vger.kernel.org, paulus@samba.org,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps
Date: Tue, 13 Nov 2001 21:02:21 -0800 (PST) [thread overview]
Message-ID: <20011113.210221.55509229.davem@redhat.com> (raw)
In-Reply-To: <3BF190F0.3FB26BD0@internetwork-ag.de>
In-Reply-To: <3BF190F0.3FB26BD0@internetwork-ag.de>
From: Till Immanuel Patzschke <tip@internetwork-ag.de>
Date: Tue, 13 Nov 2001 22:30:24 +0100
I've attached a patch, checking for headroom first, and - if necessary -
reallocating a larger buffer for the skb_push.
Please check and apply - or find a better fix!
Here is my "better fix". In pppoatm, we should be increasing the
device header length appropriately. ie. dev->hard_header_len needs to
be increased in the pppoatm driver when vc-encaps is used.
Franks a lot,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-11-14 5:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-13 21:30 [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Till Immanuel Patzschke
2001-11-14 5:02 ` David S. Miller [this message]
2001-11-14 11:13 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm andvc-encaps Till Immanuel Patzschke
2001-11-14 11:48 ` David S. Miller
2001-11-14 14:23 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Michal Ostrowski
2001-11-14 14:28 ` David S. Miller
2001-11-14 14:41 ` Till Immanuel Patzschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011113.210221.55509229.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tip@internetwork-ag.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox