From: "David S. Miller" <davem@redhat.com>
To: mostrows@speakeasy.net
Cc: tip@internetwork-ag.de, linux-kernel@vger.kernel.org,
paulus@samba.org, linux-ppp@vger.kernel.org
Subject: Re: [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps
Date: Wed, 14 Nov 2001 06:28:34 -0800 (PST) [thread overview]
Message-ID: <20011114.062834.68910928.davem@redhat.com> (raw)
In-Reply-To: <1005747834.8776.5.camel@brick.watson.ibm.com>
In-Reply-To: <3BF190F0.3FB26BD0@internetwork-ag.de> <20011113.210221.55509229.davem@redhat.com> <1005747834.8776.5.camel@brick.watson.ibm.com>
From: Michal Ostrowski <mostrows@speakeasy.net>
Date: 14 Nov 2001 09:23:53 -0500
If you look at pppoatm_send(), you'll see that you do an
skb_realloc_headroom if there's no space for the headers. If
pvcc->chan.hdrlen is set properly then this will be the exceptional,
rather than the common case.
Their problem is on receive, not send. That's problematic because in
that case the ATM drivers allocate and size the SKBs.
next prev parent reply other threads:[~2001-11-14 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-13 21:30 [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Till Immanuel Patzschke
2001-11-14 5:02 ` David S. Miller
2001-11-14 11:13 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm andvc-encaps Till Immanuel Patzschke
2001-11-14 11:48 ` David S. Miller
2001-11-14 14:23 ` [PATCH] ppp_generic causes skput:under: w/ pppoatm and vc-encaps Michal Ostrowski
2001-11-14 14:28 ` David S. Miller [this message]
2001-11-14 14:41 ` Till Immanuel Patzschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011114.062834.68910928.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mostrows@speakeasy.net \
--cc=paulus@samba.org \
--cc=tip@internetwork-ag.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox