From: Paul Mundt <pmundt@mvista.com>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] fb_mmap() holding BKL
Date: Wed, 14 Nov 2001 15:26:56 -0800 [thread overview]
Message-ID: <20011114152656.A31149@mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hello,
Just a minor cleanup.. in the event of some sanity checking in fb_mmap(), the
BKL is accidentally held on a return.. this trivial patch fixes this issue.
(Against 2.4.14).
Please apply.
Regards,
--
Paul Mundt <pmundt@mvista.com>
MontaVista Software, Inc.
--- linux/drivers/video/fbmem.c.orig Wed Nov 14 15:17:40 2001
+++ linux/drivers/video/fbmem.c Wed Nov 14 15:17:50 2001
@@ -563,8 +563,10 @@
/* memory mapped io */
off -= len;
fb->fb_get_var(&var, PROC_CONSOLE(info), info);
- if (var.accel_flags)
+ if (var.accel_flags) {
+ unlock_kernel();
return -EINVAL;
+ }
start = fix.mmio_start;
len = PAGE_ALIGN((start & ~PAGE_MASK)+fix.mmio_len);
}
[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]
next reply other threads:[~2001-11-14 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-14 23:26 Paul Mundt [this message]
2001-11-14 23:32 ` [PATCH] fb_mmap() holding BKL Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011114152656.A31149@mvista.com \
--to=pmundt@mvista.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox