public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] races in access to pci_devices
Date: Wed, 14 Nov 2001 21:24:41 -0800	[thread overview]
Message-ID: <20011114212441.B8285@kroah.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0111142257510.1095-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111142257510.1095-100000@weyl.math.psu.edu>

On Wed, Nov 14, 2001 at 11:00:26PM -0500, Alexander Viro wrote:
> 	Linus, as far as I can see there's no exclusion between
> the code that walks pci_devices and pci_insert_device().  It's
> not a big deal wrt security (not many laptops with remote access)
> but...

It's a bigger deal with large servers that have PCI Hotplug controllers.

> 	What locking is supposed to be there?

I'll add a lock to keep the problem from happening.

thanks,

greg k-h

  reply	other threads:[~2001-11-15  4:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-15  4:00 [RFC] races in access to pci_devices Alexander Viro
2001-11-15  5:24 ` Greg KH [this message]
2001-11-15  7:55 ` Jeff Garzik
2001-11-15  8:00   ` Alexander Viro
2001-11-15  8:28   ` Andrew Morton
2001-11-15 16:35     ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011114212441.B8285@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox