public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Gerd Knorr <kraxel@suse.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [kernel] kiobuf question
Date: Thu, 15 Nov 2001 18:14:45 +0100	[thread overview]
Message-ID: <20011115181445.B1381@athlon.random> (raw)
In-Reply-To: <20011115093209.A3898@bytesex.org>
In-Reply-To: <20011115093209.A3898@bytesex.org>; from kraxel@suse.de on Thu, Nov 15, 2001 at 09:32:09AM +0100

On Thu, Nov 15, 2001 at 09:32:09AM +0100, Gerd Knorr wrote:
>      83         if (PageLRU(page))
>      84                 BUG();			<<================

this is a VM bug, not a bttv bug.

One simple fix is to replace __free_page(page) in unmap_kiobuf with
page_cache_release(page). that will cure it.

But a better fix that I probably prefer for robusteness is to change in
page_alloc.c __free_pages with page_cache_release, so that we always do
this:

		if (PageLRU(page))
			lru_cache_del(page);

while freeing pages.

Andrea

           reply	other threads:[~2001-11-15 17:32 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20011115093209.A3898@bytesex.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011115181445.B1381@athlon.random \
    --to=andrea@suse.de \
    --cc=kraxel@suse.de \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox