public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: reiserfs-dev@namesys.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] reiserfs gcc alias bug only on ppc32
Date: Thu, 15 Nov 2001 20:13:40 +1100	[thread overview]
Message-ID: <20011115201340.I22552@krispykreme> (raw)


Hi,

The workaround in reiserfs for a gcc bug in some ppc32 compilers does
not affect the ppc64 compiler. A quick test to see stack usage for both
options shows:

gcc -O1
reiserfs_delete_solid_item: 976
reiserfs_rename: 960
reiserfs_cut_from_item: 880

gcc -O2
reiserfs_rename: 1008
reiserfs_delete_solid_item: 976
reiserfs_cut_from_item: 896

So there is no reason to compile reiserfs using -O1 on ppc64.

Anton


--- 2.4.15-pre4/fs/reiserfs/Makefile	Thu Nov 15 20:06:13 2001
+++ 2.4.15-pre4_work/fs/reiserfs/Makefile	Thu Nov 15 20:05:26 2001
@@ -13,13 +13,13 @@
 
 obj-m   := $(O_TARGET)
 
-# gcc -O2 (the kernel default)  is overaggressive on ppc when many inline
+# gcc -O2 (the kernel default)  is overaggressive on ppc32 when many inline
 # functions are used.  This causes the compiler to advance the stack
 # pointer out of the available stack space, corrupting kernel space,
-# and causing a panic. Since this behavior only affects ppc, this ifeq
+# and causing a panic. Since this behavior only affects ppc32, this ifeq
 # will work around it. If any other architecture displays this behavior,
 # add it here.
-ifeq ($(shell uname -m),ppc) 
+ifeq ($(CONFIG_PPC32),y)
 EXTRA_CFLAGS := -O1
 endif
 

                 reply	other threads:[~2001-11-15  9:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011115201340.I22552@krispykreme \
    --to=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-dev@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox