From: "Gérard Roudier" <groudier@free.fr>
To: "David S. Miller" <davem@redhat.com>
Cc: <anton@samba.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] small sym-2 fix
Date: Thu, 15 Nov 2001 21:41:16 +0100 (CET) [thread overview]
Message-ID: <20011115213822.C2499-100000@gerard> (raw)
In-Reply-To: <20011115.143901.121189547.davem@redhat.com>
On Thu, 15 Nov 2001, David S. Miller wrote:
> From: Gérard Roudier <groudier@free.fr>
> Date: Thu, 15 Nov 2001 20:46:34 +0100 (CET)
>
> diff -u ../sym-2-orig/sym_glue.h ./sym_glue.h
> --- ../sym-2-orig/sym_glue.h Thu Nov 15 22:53:34 2001
> +++ ./sym_glue.h Thu Nov 15 23:18:58 2001
> @@ -77,7 +77,6 @@
> #include <linux/errno.h>
> #include <linux/pci.h>
> #include <linux/string.h>
> -#include <linux/malloc.h>
> #include <linux/mm.h>
> #include <linux/ioport.h>
> #include <linux/time.h>
>
> Hmmm, why not add linux/slab.h? It exists in every Linux kernel tree
> your driver would ever be compiled under.
Just because the driver has its own allocator as you know and thus does
not need this header (it didn't need malloc.h too).
Gérard.
next prev parent reply other threads:[~2001-11-15 23:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-15 4:36 [PATCH] small sym-2 fix Anton Blanchard
2001-11-15 10:19 ` David S. Miller
2001-11-15 11:35 ` Anton Blanchard
2001-11-15 11:41 ` David S. Miller
2001-11-15 12:17 ` Anton Blanchard
2001-11-15 16:27 ` Gérard Roudier
2001-11-15 19:26 ` David S. Miller
2001-11-15 18:07 ` Gérard Roudier
2001-11-15 21:22 ` Hugh Dickins
2001-11-15 20:22 ` Gérard Roudier
2001-11-15 19:46 ` Gérard Roudier
2001-11-15 22:39 ` David S. Miller
2001-11-15 20:41 ` Gérard Roudier [this message]
2001-11-15 22:44 ` David S. Miller
2001-11-20 6:02 ` Anton Blanchard
2001-11-20 17:26 ` Gérard Roudier
2001-11-21 2:19 ` Anton Blanchard
2001-11-21 3:49 ` David S. Miller
2001-11-21 17:19 ` Gérard Roudier
2001-11-22 5:19 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011115213822.C2499-100000@gerard \
--to=groudier@free.fr \
--cc=anton@samba.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox