From: "Stephen C. Tweedie" <sct@redhat.com>
To: Ben Collins <bcollins@debian.org>,
Andrew Morton <akpm@zip.com.au>,
linux-kernel@vger.kernel.org
Cc: Stephen Tweedie <sct@redhat.com>
Subject: Re: Bug in ext3
Date: Fri, 16 Nov 2001 18:44:52 +0000 [thread overview]
Message-ID: <20011116184452.E6626@redhat.com> (raw)
In-Reply-To: <20011115092452.Z329@visi.net> <3BF3F9ED.17D55B35@zip.com.au>, <3BF3F9ED.17D55B35@zip.com.au> <20011115153442.A329@visi.net> <3BF42A1A.5AE96A78@zip.com.au> <20011115160232.H329@visi.net> <20011115145803.R5739@lynx.no> <20011115170628.J329@visi.net> <20011115162149.U5739@lynx.no> <20011116183837.D6626@redhat.com>
In-Reply-To: <20011116183837.D6626@redhat.com>; from sct@redhat.com on Fri, Nov 16, 2001 at 06:38:37PM +0000
Hi,
On Fri, Nov 16, 2001 at 06:38:37PM +0000, Stephen C. Tweedie wrote:
> Looks OK. I've done a slightly better version which catches a couple
> of extra cases but it's basically the same solution. I've also added
> a tiny patch to prevent a failed journal_wipe() from being followed by
> a journal_load() attempt, so we don't get the same error twice.
This definitely fixes that error path: I just get one, clean error
now, and no corruption of the file that was masquerading as the
journal. It doesn't properly release the journal inode, though, so we
oops on a later ext2 mount as we think we already have the (ext3)
inode in cache. Fix to follow.
Ben, thanks for this --- this level of corrupt journal is something
that hasn't been tested in this way before.
--Stephen
next prev parent reply other threads:[~2001-11-16 18:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-15 14:24 Bug in ext3 Ben Collins
2001-11-15 17:22 ` Andrew Morton
2001-11-15 20:34 ` Ben Collins
2001-11-15 20:48 ` Andrew Morton
2001-11-15 21:02 ` Ben Collins
2001-11-15 21:10 ` Andrew Morton
2001-11-15 22:04 ` Ben Collins
2001-11-15 21:58 ` Andreas Dilger
2001-11-15 22:06 ` Ben Collins
2001-11-15 22:49 ` Mike Fedyk
2001-11-15 22:58 ` Ben Collins
2001-11-15 23:21 ` Andreas Dilger
2001-11-15 23:38 ` Ben Collins
2001-11-16 0:07 ` Andreas Dilger
2001-11-16 0:55 ` Ben Collins
2001-11-16 3:09 ` Andreas Dilger
2001-11-16 3:20 ` Ben Collins
2001-11-16 3:37 ` Mike Fedyk
2001-11-16 4:50 ` Andreas Dilger
2001-11-16 18:38 ` Stephen C. Tweedie
2001-11-16 18:44 ` Stephen C. Tweedie [this message]
2001-11-16 14:52 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011116184452.E6626@redhat.com \
--to=sct@redhat.com \
--cc=akpm@zip.com.au \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox