public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jeff V. Merkey" <jmerkey@vger.timpanogas.org>
To: linux-kernel@vger.kernel.org
Cc: jmerkey@timpanogas.org
Subject: st.c SCSI Tape ioctl() bug
Date: Sun, 18 Nov 2001 20:48:19 -0700	[thread overview]
Message-ID: <20011118204819.A968@vger.timpanogas.org> (raw)



Kai/Linux,

The ioctl() function to enable/disable code 15 comrpession has 
some problems.  I have a fix to the code, but it does not 
always seem to work properly, so I think you should do this 
review.  

If you call the ioctl() tape command from kernel space to 
enable and disable **DEFAULT** compression (not MTCOMPRESSION
ioctl, the MT_ST_DEF_COMPRESSION code path) there is a case
where the default_compression/compression_changed flags
can horribly out of sync.

Please take a look at this code.  We have gotten around it 
by simply calling MTCOMPRESSION everytime we need to use it,
however, but the other path seems busted, and it would be 
nice for it to work properly.

Thanks,

Jeff


             reply	other threads:[~2001-11-19  2:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-19  3:48 Jeff V. Merkey [this message]
2001-11-21 21:58 ` st.c SCSI Tape ioctl() bug Kai Makisara
2001-11-21 22:14   ` Jeff Merkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011118204819.A968@vger.timpanogas.org \
    --to=jmerkey@vger.timpanogas.org \
    --cc=jmerkey@timpanogas.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox