From: Erik Andersen <andersen@codepoet.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix SCSI non-blocksize reads
Date: Thu, 22 Nov 2001 10:20:54 -0700 [thread overview]
Message-ID: <20011122102054.A11961@codepoet.org> (raw)
In-Reply-To: <20011122014131.A16981@codepoet.org> <Pine.LNX.4.33.0111220908010.1383-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.33.0111220908010.1383-100000@penguin.transmeta.com>
On Thu Nov 22, 2001 at 09:09:23AM -0800, Linus Torvalds wrote:
>
> On Thu, 22 Nov 2001, Erik Andersen wrote:
> >
> > Several SCSI drivers blindly do reads of size 1024 when trying to read
> > the partition table. This fails on Magneto Optical drives and similar
> > odd devices with 2048 byte native sector sizes. This patch fixes that
> > so I can have partitions on my MO drive again (it lives on an Adaptec
> > card at present and has 2048 byte sectors),
>
> Please use the "block_size()" function instead of doing it by hand..
Ok. I just did it the same way most of the other SCSI drivers
do this...
Would you like a patch that also fixes all the other SCSI drivers
to use block_size() then, so they will be consistent?
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
next prev parent reply other threads:[~2001-11-22 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-22 6:44 Linux-2.4.15-pre9 Linus Torvalds
2001-11-22 7:47 ` Linux-2.4.15-pre9 Anuradha Ratnaweera
2001-11-22 18:52 ` Linux-2.4.15-pre9 Linus Torvalds
2001-11-22 19:34 ` Linux-2.4.15-pre9 Alexander Viro
2001-11-22 19:46 ` Linux-2.4.15-pre9 Tom Rini
2001-11-23 16:20 ` Linux-2.4.15-pre9 Michael H. Warfield
2001-11-26 11:52 ` PATCH 2.5.0 kill read_ahead array Martin Dalecki
2001-11-26 16:34 ` Andreas Dilger
2001-11-26 16:53 ` Martin Dalecki
2001-11-22 19:16 ` Linux-2.4.15-pre9 Tim Schmielau
2001-11-26 15:18 ` Linux-2.4.15-pre9 bill davidsen
2001-11-22 8:41 ` [PATCH] fix SCSI non-blocksize reads Erik Andersen
2001-11-22 17:09 ` Linus Torvalds
2001-11-22 17:20 ` Erik Andersen [this message]
2001-11-22 18:40 ` Linus Torvalds
2001-11-24 0:04 ` Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011122102054.A11961@codepoet.org \
--to=andersen@codepoet.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox