From: "J.A. Magallon" <jamagallon@able.es>
To: vda <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: Stevie O <stevie@qrpff.net>,
Vincent Sweeney <v.sweeney@dexterus.com>,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] Bad #define, nonportable C, missing {}
Date: Fri, 23 Nov 2001 15:43:09 +0100 [thread overview]
Message-ID: <20011123154309.A1791@werewolf.able.es> (raw)
In-Reply-To: <01112112401703.01961@nemo> <5.1.0.14.2.20011121232051.01dab468@whisper.qrpff.net> <20011122210801.A1514@werewolf.able.es> <01112311540300.00886@manta>
In-Reply-To: <01112311540300.00886@manta>; from vda@port.imtp.ilyichevsk.odessa.ua on Fri, Nov 23, 2001 at 14:54:03 +0100
On 20011123 vda wrote:
>On Thursday 22 November 2001 18:08, J.A. Magallon wrote:
>> On 20011122 Stevie O wrote:
>> >If we were going to be semiobscure, wouldn't the correct code be
>> >
>> >#define MODINC(x,y) (x = ++x % y)
>>
>> But the question is: Is this kind of code worth the discussion ? AFAIK,
>
>It worth fixing. That macro is really bad: as you can see, people cannot
That was my point, don't ever try to guess if it does what it is intended
to do, just change it.
--
J.A. Magallon # Let the source be with you...
mailto:jamagallon@able.es
Mandrake Linux release 8.2 (Cooker) for i586
Linux werewolf 2.4.15-pre9 #1 SMP Thu Nov 22 16:16:54 CET 2001 i686
next prev parent reply other threads:[~2001-11-23 14:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-21 12:40 [BUG] Bad #define, nonportable C, missing {} vda
2001-11-21 11:10 ` Andreas Schwab
2001-11-21 11:16 ` Tim Waugh
2001-11-21 12:31 ` Ragnar Hojland Espinosa
2001-11-21 13:40 ` Jan Hudec
2001-11-21 14:19 ` Andreas Schwab
2001-11-21 14:52 ` Alexander Viro
2001-11-21 18:23 ` Neil Booth
2001-11-21 12:35 ` Vincent Sweeney
2001-11-21 13:37 ` Jan Hudec
2001-11-21 13:52 ` Mathijs Mohlmann
2001-11-21 17:12 ` vda
2001-11-26 20:28 ` Alan Cox
2001-11-27 18:03 ` vda
2001-11-27 18:38 ` Andreas Dilger
2001-11-28 13:19 ` vda
2001-11-21 14:12 ` Richard B. Johnson
2001-11-21 14:33 ` Eric W. Biederman
2001-11-21 14:56 ` Alexander Viro
2001-11-21 14:59 ` Andreas Schwab
2001-11-21 15:48 ` Momchil Velikov
2001-11-21 16:52 ` vda
2001-11-21 14:24 ` Sean Hunter
2001-11-21 14:25 ` Andreas Schwab
2001-11-22 20:43 ` Chris Gray
2001-11-22 4:24 ` Stevie O
2001-11-22 11:46 ` Horst von Brand
2001-11-22 12:03 ` Alexander Viro
2001-11-22 20:08 ` J.A. Magallon
[not found] ` <01112311540300.00886@manta>
2001-11-23 14:43 ` J.A. Magallon [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-11-27 19:03 Nathan Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011123154309.A1791@werewolf.able.es \
--to=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=stevie@qrpff.net \
--cc=v.sweeney@dexterus.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox