public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolabs.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Moving ext3 journal file
Date: Fri, 23 Nov 2001 17:41:20 -0700	[thread overview]
Message-ID: <20011123174120.Q1308@lynx.no> (raw)
In-Reply-To: <E167Fuw-00001K-00@DervishD> <Pine.LNX.4.33.0111231944430.2891-100000@fargo> <20011123155901.C1308@lynx.no> <9tmocg$jfn$1@cesium.transmeta.com>
In-Reply-To: <9tmocg$jfn$1@cesium.transmeta.com>; from hpa@zytor.com on Fri, Nov 23, 2001 at 04:07:44PM -0800

On Nov 23, 2001  16:07 -0800, H. Peter Anvin wrote:
> By author:    Andreas Dilger <adilger@turbolabs.com>
> > Don't do that.  That is only good if the filesystem thinks that there
> > is no journal, or it is using a hidden inode for the journal (i.e. if
> > you run "tune2fs -l /dev/whatever" and it doesn't have "has_journal"
> > listed in the filesystem features (this is what happened with 2.4.10).
> > Otherwise, you will delete your real journal, tune2fs will complain,
> > and then you will need to run e2fsck to clean up after yourself, before
> > re-creating your journal again.
> > 
> > If you have a filesystem with a .journal file, and you want to "hide"
> > it, just run e2fsck 1.25 while the filesystem is unmounted, and it
> > will do it for you.  If you don't want to have a .journal in the first
> > place, run tune2fs -j while the filesystem is unmounted.
> 
> This is all fine and good except for the root partition (I'm pleased
> to hear that e2fsck 1.25 will move the journal to the hidden inode for
> non-root partitions.)  It would be nice if this was done automagically
> by the mounting code instead of by fsck; that way migration would
> truly be painless.

Hmm, it could be added into the in-kernel ext3 journal recovery code, maybe,
possibly, but it would be ugly I think.  I really don't see it as being a
problem (other than a purely cosmetic one) to have a .journal file in your
root fs.  I lived with these for a couple of years OK (even some of the
early ext3 tools called them "journal.dat" (i.e. not a leading dot, ugh).

In 2.5 it would be easy (and preferrable for other reasons) to have e2fsck
run from the initramfs on the root fs before it is mounted.  That solves
the problem nicely without adding bloat into the kernel.  We could even
remove the in-kernel journal recovery at that point if we thought that the
initramfs was a reliable environment to host _critical_ boot tools. 

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/


  reply	other threads:[~2001-11-24  0:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-23 12:58 Moving ext3 journal file RaúlNúñez de Arenas Coronado
2001-11-23 18:20 ` Andreas Dilger
2001-11-24  1:02 ` David Gómez 
2001-11-23 22:59   ` Andreas Dilger
2001-11-24  0:07     ` H. Peter Anvin
2001-11-24  0:41       ` Andreas Dilger [this message]
2001-11-24  0:56         ` H. Peter Anvin
2001-11-24  4:25           ` Andreas Dilger
2001-11-24  5:05             ` H. Peter Anvin
2001-11-24 11:37               ` Michael Zimmermann
2001-11-25 10:33                 ` Mike Fedyk
2001-11-25 11:14                   ` Mike Castle
2001-11-25 22:55                     ` Mike Fedyk
2001-11-25 23:55                       ` Mike Fedyk
2001-11-24 17:26               ` Jamie Lokier
2001-11-24 17:49               ` Thorsten Glaser
2001-11-24 10:54       ` Marcel J.E. Mol
2001-11-24 21:19         ` Mike Castle
2001-11-24 22:49           ` Andreas Dilger
2001-11-25  3:34             ` Mike Castle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011123174120.Q1308@lynx.no \
    --to=adilger@turbolabs.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox