From: Stephan von Krawczynski <skraw@ithnet.com>
To: Didier Moens <Didier.Moens@dmb001.rug.ac.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: OOPS in agpgart (2.4.13, 2.4.15pre7)
Date: Fri, 23 Nov 2001 18:00:19 +0100 [thread overview]
Message-ID: <20011123180019.24c19be3.skraw@ithnet.com> (raw)
In-Reply-To: <3BFE8799.4070307@dmb.rug.ac.be>
In-Reply-To: <3BFE8799.4070307@dmb.rug.ac.be>
On Fri, 23 Nov 2001 18:30:01 +0100
Didier Moens <Didier.Moens@dmb.rug.ac.be> wrote:
>
> Hi all,
>
>
> This is my first oops report on lkml, so please be gentle with me. :)
>
>
> Hardware : IBM A30p (P3-1.2 GHz) with Intel i830 and ATI M6 Radeon
> Mobility LY
>
>
> Symptoms : oops when modprobing agpgart, both in the RedHat 2.4.13-0.6
> kernel and in a vanilla 2.4.15pre7.
Hello,
could be that this code from /drivers/char/agp/agpgart_be.c is bogus:
case PCI_DEVICE_ID_INTEL_830_M_0:
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
NULL);
===> if(PCI_FUNC(i810_dev->devfn) != 0) {
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
i810_dev);
}
if (i810_dev == NULL) {
printk(KERN_ERR PFX "Detected an "
"Intel 830M, but could not find the"
" secondary device.\n");
agp_bridge.type = NOT_SUPPORTED;
return -ENODEV;
}
printk(KERN_INFO PFX "Detected an Intel "
"830M Chipset.\n");
agp_bridge.type = INTEL_I810;
return intel_i830_setup(i810_dev);
Try this patch:
--- agpgart_be.c-orig Fri Nov 23 17:57:24 2001
+++ agpgart_be.c Fri Nov 23 17:55:24 2001
@@ -3879,7 +3879,7 @@
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
NULL);
+ if(i810_dev && ( PCI_FUNC(i810_dev->devfn) != 0) ) {
- if(PCI_FUNC(i810_dev->devfn) != 0) {
i810_dev = pci_find_device(PCI_VENDOR_ID_INTEL,
PCI_DEVICE_ID_INTEL_830_M_1,
i810_dev);
next prev parent reply other threads:[~2001-11-23 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-23 17:30 OOPS in agpgart (2.4.13, 2.4.15pre7) Didier Moens
2001-11-23 17:00 ` Stephan von Krawczynski [this message]
2001-11-24 22:34 ` Didier Moens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011123180019.24c19be3.skraw@ithnet.com \
--to=skraw@ithnet.com \
--cc=Didier.Moens@dmb001.rug.ac.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox