Re: 2.4.15-pre9 breakage (inode.c)

Andrea Arcangeli
2001-11-24T07:12:21Z

On Sat, Nov 24, 2001 at 02:06:32AM -0500, Alexander Viro wrote:
>
>
> On Sat, 24 Nov 2001, Andrea Arcangeli wrote:
>
> > this one looks even better (and it doesn't need to propagate the fix to
> > the lowlevel):
> >
> > --- 2.4.15aa1/fs/super.c.~1~ Fri Nov 23 08:21:01 2001
> > +++ 2.4.15aa1/fs/super.c Sat Nov 24 07:58:37 2001
> > @@ -470,6 +470,7 @@
> > return s;
> >
> > out_fail:
> > + invalidate_inodes(s);
>
> Sigh...
> a) grep, please.
> b) you are triggering method calls for a superblock after failed
> ->read_super(). Blindly. Care to audit all filesystems and check that
> it is legitimate?

if the method or the s_op isn't defined it will do nothing, if it is
defined it'd better do something not wrong because the fs just did an
iget within read_super. I don't see obvious troubles and the above looks
better than making iput more complex (and nitpicking slower 8).

Andrea