From: Rolf Fokkens <fokkensr@linux06.vertis.nl>
To: linux-kernel@vger.kernel.org
Subject: ip_queue_xmit2 inconsistency regarding skb->sk
Date: Wed, 28 Nov 2001 12:26:51 +0100 [thread overview]
Message-ID: <200111281126.MAA13610@linux06.vertis.nl> (raw)
Hi!
I posted a kernel oops related to netfilter/REDIRECT. It seems like
ip_queue_xmit2 crashes on (skb->sk == NULL) in calling
ip_dont_fragment(sk, &rt->u.dst)
which can't handle the (sk == NULL) situation. Of course there is the matter of
why (sk == NULL) in the first place. Haven't figured that out yet, nf_hook_slow
may cause do this somehow.
The other matter however is wether or not ip_queue_xmit2 should be able to
handle the (skb->sk == NULL) situation. The code is not consistent on that
subject.
It seems like the if statement:
if (skb_headroom(skb) < dev->hard_header_len && dev->hard_header) {
handles the (sk == NULL) situation, given the line "if (sk)". Other parts of
ip_queue_xmit2 seem to assume (sk != NULL), like the ip_dont_fragment call
or lines like "skb->priority = sk->priority".
OK, this is not the answer on the why of the kernel oops. I hope however that
this question is related and helps in finding the answer
Rolf
reply other threads:[~2001-11-28 11:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200111281126.MAA13610@linux06.vertis.nl \
--to=fokkensr@linux06.vertis.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox