From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] fix for drivers/char/pc_keyb.c in 2.5.1-pre3
Date: Wed, 28 Nov 2001 16:38:10 -0800 [thread overview]
Message-ID: <20011128163810.C2512@kroah.com> (raw)
Hi,
Here's a patch for 2.5.1-pre3 to fix the compile time problems in
drivers/char/pc_keyb.c. It also fixes the places where the flags
variable is the wrong type.
thanks,
greg k-h
diff -Nru a/drivers/char/pc_keyb.c b/drivers/char/pc_keyb.c
--- a/drivers/char/pc_keyb.c Wed Nov 28 16:34:37 2001
+++ b/drivers/char/pc_keyb.c Wed Nov 28 16:34:37 2001
@@ -420,7 +420,7 @@
kbd_write_command(KBD_CCMD_WRITE_MODE);
kb_wait();
kbd_write_output(AUX_INTS_OFF);
- spin_unlock(&kbd_controller_lock, flags);
+ spin_unlock(&kbd_controller_lock);
}
spin_unlock_irqrestore( &aux_count_lock,flags );
}
@@ -433,7 +433,7 @@
static inline void handle_mouse_event(unsigned char scancode)
{
#ifdef CONFIG_PSMOUSE
- int flags;
+ unsigned long flags;
static unsigned char prev_code;
if (mouse_reply_expected) {
if (scancode == AUX_ACK) {
@@ -1052,9 +1052,9 @@
static int release_aux(struct inode * inode, struct file * file)
{
- int flags;
+ unsigned long flags;
fasync_aux(-1, file, 0);
- spin_lock_irqsave( &aux_count, flags );
+ spin_lock_irqsave( &aux_count_lock, flags );
if ( --aux_count ) {
spin_unlock_irqrestore( &aux_count_lock );
return 0;
@@ -1073,7 +1073,7 @@
static int open_aux(struct inode * inode, struct file * file)
{
- int flags;
+ unsigned long flags;
spin_lock_irqsave( &aux_count_lock, flags );
if ( aux_count++ ) {
spin_unlock_irqrestore( &aux_count_lock );
next reply other threads:[~2001-11-29 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-29 0:38 Greg KH [this message]
2001-11-29 0:55 ` [PATCH] fix for drivers/char/pc_keyb.c in 2.5.1-pre3 Alan Cox
2001-11-29 1:07 ` Greg KH
2001-11-29 1:47 ` CONFIG_IPv8_TOS for 2.4 Jim Fleming
2001-11-29 7:40 ` [PATCH] fix for drivers/char/pc_keyb.c in 2.5.1-pre3 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011128163810.C2512@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox