From: Victor Yodaiken <yodaiken@fsmlabs.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: "David C. Hansen" <haveblue@us.ibm.com>,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove BKL from drivers' release functions
Date: Fri, 30 Nov 2001 05:41:26 -0700 [thread overview]
Message-ID: <20011130054126.A18099@hq2> (raw)
In-Reply-To: <3C057410.3090201@us.ibm.com> <Pine.GSO.4.21.0111300444180.13367-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111300444180.13367-100000@weyl.math.psu.edu>
On Fri, Nov 30, 2001 at 04:57:28AM -0500, Alexander Viro wrote:
> In other words, patch is completely bogus. BKL removal may be a good
> idea, but you really need to audit the code. Which requires at least
> some understanding of the things you are doing. There _are_ races
> and they need to be dealt with. But blind BKL removal doesn't fix any
> and breaks quite a few places where the code was actually correct.
People seem to believe that BKL is worse than added spin-locks, but I
very much doubt this is always true.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-11-30 12:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-28 23:05 [PATCH] remove BKL from drivers' release functions David C. Hansen
2001-11-28 23:29 ` Andrew Morton
2001-11-28 23:42 ` David C. Hansen
2001-11-28 23:50 ` Robert Love
2001-11-28 23:36 ` Alan Cox
2001-11-28 23:32 ` David C. Hansen
2001-11-28 23:45 ` Russell King
2001-11-29 0:26 ` David C. Hansen
2001-11-29 0:37 ` Jeff Garzik
2001-11-29 0:41 ` Russell King
2001-11-29 1:33 ` David C. Hansen
2001-11-29 1:42 ` Jeff Garzik
2001-11-29 7:17 ` Oliver Neukum
2001-11-29 1:47 ` Alan Cox
2001-11-29 9:15 ` Russell King
2001-11-29 13:55 ` BALBIR SINGH
2001-11-30 19:30 ` Rick Lindsley
2001-11-30 9:57 ` Alexander Viro
2001-11-30 12:41 ` Victor Yodaiken [this message]
2001-11-30 20:02 ` Rick Lindsley
2001-11-30 19:38 ` David C. Hansen
2001-11-30 23:12 ` Alexander Viro
2001-12-01 0:47 ` Rick Lindsley
2001-12-01 9:52 ` Alan Cox
2001-12-01 10:06 ` Rick Lindsley
2001-11-30 20:11 ` Rick Lindsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011130054126.A18099@hq2 \
--to=yodaiken@fsmlabs.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox