From: Jens Axboe <axboe@suse.de>
To: Alexander Viro <viro@math.psu.edu>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>,
Linus Torvalds <torvalds@transmeta.com>,
Linux-Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: PATCH 2.5.1.4: fix rd.c build
Date: Fri, 30 Nov 2001 08:28:55 +0100 [thread overview]
Message-ID: <20011130082855.E16796@suse.de> (raw)
In-Reply-To: <20011130081804.D16796@suse.de> <Pine.GSO.4.21.0111300221300.13299-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111300221300.13299-100000@weyl.math.psu.edu>
On Fri, Nov 30 2001, Alexander Viro wrote:
>
>
> On Fri, 30 Nov 2001, Jens Axboe wrote:
>
> > Actually, this is not even enough if rd receives a multi page bio.
> > Something like this should work, untested.
> >
> > @@ -237,9 +238,9 @@
> > err = -EIO;
>
> Make it err = 0...
Explain
> Another thing being, if you remove explicit call of rd_init() from
> ll_rw_blk.c making module_init() unconditional looks like a good
> idea...
Indeed, done.
--
Jens Axboe
next prev parent reply other threads:[~2001-11-30 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-30 1:18 PATCH 2.5.1.4: fix rd.c build Jeff Garzik
2001-11-30 7:18 ` Jens Axboe
2001-11-30 7:24 ` Alexander Viro
2001-11-30 7:28 ` Jens Axboe [this message]
2001-11-30 7:37 ` Alexander Viro
2001-11-30 7:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011130082855.E16796@suse.de \
--to=axboe@suse.de \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox