Re: PATCH 2.5.4 i810_audio, bttv, working at all.

Martin Dalecki
2002-02-13T12:56:23Z

David S. Miller wrote:

> From: Martin Dalecki <dalecki@evision-ventures.com>
> Date: Wed, 13 Feb 2002 13:40:59 +0100
>
> Of course I admit that I have taken the easy shoot here. But it wasn't
> possible
> to me to deduce the proper thing to do by looking at the patches.
> This is the usual way I deal with API changes: Have a look at what has
> been done
> to the other candidates and do the analogous thing where you need it.
>
>The API hasn't changed, it is being enforced. The PCI DMA api
>has existed for years. Please read Documentation/DMA-mapping.txt
>so that you may learn how to properly convert drivers.
>
> But please just show me a non x86 architecture which is using the
> i810_audio driver!
>
>Because if all drivers are consistently using the portable interfaces,
>people writing new drivers will know exactly what to do.
>
Agred. I see now in patch-2.5.2 and the changes to ymfpci.c how to deal
with this.
I was already suspicious that the continuous back and forth address
space conversion
in bttv.c could be dealt with by just doing it once at initialization
time and storing both
the physical and virtuall mapping. Will do it, when I have pyhsical
access to the corresponding
hardware at hand.