Re: Linux 2.4.17-pre4

[Tim Waugh <twaugh@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Wed, Dec 05, 2001 at 10:54:26PM +0100, Jakob Kemi wrote:

> Since 2.4.14 the ieee1284 parport functions have worked improperly
> for some drivers (CPiA, W9966 and others). Joe
> <joeja@mindspring.com> was quick to find the failure. He said he was
> going to send the patch to you some week ago and maybe he already
> have. If it somehow got lost in an internet black-hole or something
> I try to also send it to you. It's just a one-liner which reverts to
> pre-2.4.14 behavior.

I am the maintainer of this code.  Why is this the first time that I
have seen this patch (or even heard of a problem report)?  Marcelo,
please don't apply it.

The correct fix is to change:

ctl &= ~(PARPORT_CONTROL_STROBE | PARPORT_CONTROL_INIT);

so that it also turns off AUTOFD as well.

I have several patches queued up for parport (see
http://people.redhat.com/twaugh/patches/).  It would be very helpful
to me if you could first send changes to me rather than Marcelo or
Linus, so that merging is not made more difficult.  In addition, there
is a ChangeLog file in that directory; changing the code without
updating the ChangeLog makes my attempt to keep it current futile. :-(

Tim.
*/

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]