Linux 2.4.17-pre4

Linux 2.4.17-pre4

[Marcelo Tosatti]

Duh. I forgot to add tcp_diag.c and tcp_diag.h in -pre3, which avoid it to
compile correctly.

Well, here goes -pre4 which fixes that.

- Added missing tcp_diag.c and tcp_diag.h       (me)

Re: Linux 2.4.17-pre4

[Jakob Kemi]

On Wednesdayen den 5 December 2001 19.41, Marcelo Tosatti wrote:
> Duh. I forgot to add tcp_diag.c and tcp_diag.h in -pre3, which avoid it to
> compile correctly.
>
> Well, here goes -pre4 which fixes that.
>
> - Added missing tcp_diag.c and tcp_diag.h       (me)
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Hi Marcelo,

Since 2.4.14 the ieee1284 parport functions have worked improperly for some 
drivers (CPiA, W9966 and others). Joe <joeja@mindspring.com> was quick to 
find the failure. He said he was going to send the patch to you some week ago 
and maybe he already have. If it somehow got lost in an internet black-hole 
or something I try to also send it to you. It's just a one-liner which 
reverts to pre-2.4.14 behavior.

--- ieee1284_ops.c.orig	Tue Nov  6 11:29:26 2001
+++ ieee1284_ops.c	Wed Dec  5 22:44:20 2001
@@ -592,7 +592,7 @@
 		}

 		/* Event 44: Set HostAck high, acknowledging handshake. */
-		parport_write_control (port, ctl);
+		parport_frob_control (port, PARPORT_CONTROL_AUTOFD, 0);

 		/* Event 45: The peripheral has 35ms to set nAck high. */
 		if (parport_wait_peripheral (port, PARPORT_STATUS_ACK,

Re: Linux 2.4.17-pre4

[Tim Waugh]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On Wed, Dec 05, 2001 at 10:54:26PM +0100, Jakob Kemi wrote:

> Since 2.4.14 the ieee1284 parport functions have worked improperly
> for some drivers (CPiA, W9966 and others). Joe
> <joeja@mindspring.com> was quick to find the failure. He said he was
> going to send the patch to you some week ago and maybe he already
> have. If it somehow got lost in an internet black-hole or something
> I try to also send it to you. It's just a one-liner which reverts to
> pre-2.4.14 behavior.

I am the maintainer of this code.  Why is this the first time that I
have seen this patch (or even heard of a problem report)?  Marcelo,
please don't apply it.

The correct fix is to change:

ctl &= ~(PARPORT_CONTROL_STROBE | PARPORT_CONTROL_INIT);

so that it also turns off AUTOFD as well.

I have several patches queued up for parport (see
http://people.redhat.com/twaugh/patches/).  It would be very helpful
to me if you could first send changes to me rather than Marcelo or
Linus, so that merging is not made more difficult.  In addition, there
is a ChangeLog file in that directory; changing the code without
updating the ChangeLog makes my attempt to keep it current futile. :-(

Tim.
*/

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: Linux 2.4.17-pre4

[Jakob Kemi]

On Wednesday, 5 December 2001 23.18, Tim Waugh wrote:
> On Wed, Dec 05, 2001 at 10:54:26PM +0100, Jakob Kemi wrote:
> > Since 2.4.14 the ieee1284 parport functions have worked improperly
> > for some drivers (CPiA, W9966 and others). Joe
> > <joeja@mindspring.com> was quick to find the failure. He said he was
> > going to send the patch to you some week ago and maybe he already
> > have. If it somehow got lost in an internet black-hole or something
> > I try to also send it to you. It's just a one-liner which reverts to
> > pre-2.4.14 behavior.
>
> I am the maintainer of this code.  Why is this the first time that I
> have seen this patch (or even heard of a problem report)?  Marcelo,

Dunno, It's been a couple of mails about it on the list, under the topic CPIA 
is broke and then later '2.4.14/2.4.15 cpia driver IS broke.. no its parport'

> please don't apply it.
>
> The correct fix is to change:
>
> ctl &= ~(PARPORT_CONTROL_STROBE | PARPORT_CONTROL_INIT);
>
> so that it also turns off AUTOFD as well.
>
> I have several patches queued up for parport (see

Nice, I hope it gets in before 2.4.17.


> http://people.redhat.com/twaugh/patches/).  It would be very helpful
> to me if you could first send changes to me rather than Marcelo or

Sounds good to me, I'll do that next time. It was just that I heard the 25 of 
nov. that the patch was sent by joe and I just wanted to make sure that it 
didn't dissapear in the noise.

Regards,
	Jakob

Re: Linux 2.4.17-pre4

[Tim Waugh]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Thu, Dec 06, 2001 at 01:22:52AM +0100, Jakob Kemi wrote:

> Dunno, It's been a couple of mails about it on the list, under the
> topic CPIA is broke and then later '2.4.14/2.4.15 cpia driver IS
> broke.. no its parport'

Okay, I guess I skimmed too fast..

> Sounds good to me, I'll do that next time. It was just that I heard
> the 25 of nov. that the patch was sent by joe and I just wanted to
> make sure that it didn't dissapear in the noise.

It probably would have otherwise.

Thanks,
Tim.
*/

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]