From: Jakub Jelinek <jakub@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "David S. Miller" <davem@redhat.com>,
jgarzik@mandrakesoft.com, kaos@ocs.com.au,
marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.16 for pointers to __devexit functions
Date: Thu, 6 Dec 2001 04:50:41 -0500 [thread overview]
Message-ID: <20011206045041.F4087@devserv.devel.redhat.com> (raw)
In-Reply-To: <20011206.001423.118949508.davem@redhat.com> <11777.1007619756@kao2.melbourne.sgi.com> <3C0F27CA.59C22DEF@mandrakesoft.com> <20011206.001423.118949508.davem@redhat.com> <15133.1007631619@redhat.com>
In-Reply-To: <15133.1007631619@redhat.com>; from dwmw2@infradead.org on Thu, Dec 06, 2001 at 09:40:19AM +0000
On Thu, Dec 06, 2001 at 09:40:19AM +0000, David Woodhouse wrote:
>
> davem@redhat.com said:
> > > Why not __attribute__((weak)) ?
> > This doesn't work on all platforms unfortunately :(
>
> Doesn't work at all, or just doesn't work with the (current) minimum
> recommended compiler? We have to increase those minima at some point.
Actually, I think all GCCs will error on it, or at least should.
Most of the __devexit routines are static, you get something like:
test.c:2: weak declaration of `foo' must be public
It is very weird thing to have a non-public weak, and assemblers will do
weird things if you tweak it in assembly output.
Jakub
next prev parent reply other threads:[~2001-12-06 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-06 6:22 [patch] 2.4.16 for pointers to __devexit functions Keith Owens
2001-12-06 8:09 ` Jeff Garzik
2001-12-06 8:14 ` David S. Miller
2001-12-06 9:40 ` David Woodhouse
2001-12-06 9:41 ` Jeff Garzik
2001-12-06 10:17 ` Alan Cox
2001-12-06 9:50 ` Jakub Jelinek [this message]
2001-12-06 10:15 ` David S. Miller
2001-12-06 10:22 ` Jakub Jelinek
2001-12-06 9:54 ` Keith Owens
2001-12-06 16:21 ` Marcelo Tosatti
2001-12-06 16:22 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011206045041.F4087@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=davem@redhat.com \
--cc=dwmw2@infradead.org \
--cc=jgarzik@mandrakesoft.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox