From: David Weinehall <tao@acc.umu.se>
To: Robert Love <rml@tech9.net>
Cc: marcelo@conectiva.com.br, andre@linux-ide.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] simple ide without proc compile fix
Date: Thu, 6 Dec 2001 05:48:26 +0100 [thread overview]
Message-ID: <20011206054826.Z360@khan.acc.umu.se> (raw)
In-Reply-To: <1007594451.28567.18.camel@phantasy>
In-Reply-To: <1007594451.28567.18.camel@phantasy>; from rml@tech9.net on Wed, Dec 05, 2001 at 06:20:49PM -0500
On Wed, Dec 05, 2001 at 06:20:49PM -0500, Robert Love wrote:
> Attached patch is a repost now against 2.4.17-pre4.
>
> IDE will not compile without CONFIG_PROC_FS defined. This patch fixes
> that.
>
> Yes, ifdefs in the code are not preferred. But this is merely following
> the pattern in the rest of the ide*.c files (see other uses of
> ide_remove_proc_entries -- just these two seem to be without ifdefs).
Wouldn't a dummy, in case of no proc, be preferable? That'd make it
possible to remove all the #ifdef CONFIG_PROC_FS
/David
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
next prev parent reply other threads:[~2001-12-06 4:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-05 23:20 [PATCH] simple ide without proc compile fix Robert Love
2001-12-06 4:48 ` David Weinehall [this message]
2001-12-06 5:08 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011206054826.Z360@khan.acc.umu.se \
--to=tao@acc.umu.se \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox