Re: new bio: compile fix for alpha

["Jeff V. Merkey" <jmerkey@vger.timpanogas.org>]

Jens,

This interface is totally cool and much appreciated.  I am 
nearly done getting the page cache mapped into NWFS.  I am 
waiting for the bugs to settle down, I still see some issues
with the AHA1512 drivers, but IDE works great and is 
really fast.

Jeff


On Thu, Dec 06, 2001 at 07:23:18PM +0100, Jens Axboe wrote:
> On Thu, Dec 06 2001, Ivan Kokshaysky wrote:
> > On Thu, Nov 29, 2001 at 03:23:39PM +0100, Jens Axboe wrote:
> > > Please send whatever you find, thanks.
> > 
> > Well, I think this one is critical - in -pre4 BIO_CONTIG macro
> > has been changed:
> > -	(bio_to_phys((bio)) + bio_size((bio)) == bio_to_phys((nxt)))
> > +	(bvec_to_phys(__BVEC_END((bio)) + (bio)->bi_size) ==bio_to_phys((nxt)))
> > 		      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This means that you add size in bytes to the `struct bio_vec' pointer,
> > which is obviously bogus. I wonder why this typo didn't expose itself
> > on x86 - on alpha I've got an oops on very first disk i/o in partition
> > check...
> 
> Irk, good spotting. Thanks!
> 
> > The rest is cleaning up some format vs. arg inconsistency on 64-bit
> > platforms.
> > Oh, and yet another [incorrect] BUG_ON macro on alpha killed.
> 
> Applied, although I think we'll make BUG_ON a kernel generic and not
> platform specific as per Rusty's patch.
> 
> -- 
> Jens Axboe
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/