* ymfpci bugfix
@ 2001-12-08 17:13 Pete Zaitcev
0 siblings, 0 replies; only message in thread
From: Pete Zaitcev @ 2001-12-08 17:13 UTC (permalink / raw)
To: marcelo; +Cc: linux-kernel
Hi, Marcelo:
In a true display of "never say never" case, here is an unanticipated
bugfix for ymfpci in 2.4 (RH Bug 56977). It applies on top and/or
independently from other 2.4 fixes (perhaps with offset to 41 lines).
Thanks,
-- Pete
--- linux-2.4.16/drivers/sound/ymfpci.c Mon Nov 19 14:53:19 2001
+++ linux-2.4.16-niph/drivers/sound/ymfpci.c Fri Dec 7 23:52:39 2001
@@ -2162,12 +2203,15 @@
{
u8 cmd;
+ /*
+ * In the 744, 754 only 0x01 exists, 0x02 is undefined.
+ * It does not seem to hurt to trip both regardless of revision.
+ */
pci_read_config_byte(pci, PCIR_DSXGCTRL, &cmd);
- if (cmd & 0x03) {
- pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd & 0xfc);
- pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd | 0x03);
- pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd & 0xfc);
- }
+ pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd & 0xfc);
+ pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd | 0x03);
+ pci_write_config_byte(pci, PCIR_DSXGCTRL, cmd & 0xfc);
+
pci_write_config_word(pci, PCIR_DSXPWRCTRL1, 0);
pci_write_config_word(pci, PCIR_DSXPWRCTRL2, 0);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-12-08 17:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-12-08 17:13 ymfpci bugfix Pete Zaitcev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox