2.5.1-pre7 ide-cd module

2.5.1-pre7 ide-cd module

[Pierre Rousselet]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Attached is dmesg with 2.5.1-pre7 + devfs-patch-v203.

The first and second manual loading of the ide-cd module give something
different.

#modprobe ide-cd ; rmmod ide-cd ; modprobe ide-cd

hdc: ATAPI CD-ROM drive, 0kB Cache, DMA
Uniform CD-ROM driver Revision: 3.12
hdc: ATAPI 24X CD-ROM drive, 128kB Cache, DMA

Why ?

Pierre
-- 
------------------------------------------------
 Pierre Rousselet <pierre.rousselet@wanadoo.fr>
------------------------------------------------

[-- Attachment #2: MESS --]
[-- Type: text/plain, Size: 6222 bytes --]

Linux version 2.5.1-pre7+devfs-v203 (root@milou) (gcc version 2.95.3 20010315 (release)) #1 sam déc 8 16:20:55 CET 2001
BIOS-provided physical RAM map:
 BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
 BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
 BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
 BIOS-e820: 0000000000100000 - 0000000010000000 (usable)
 BIOS-e820: 00000000ffff0000 - 0000000100000000 (reserved)
On node 0 totalpages: 65536
zone(0): 4096 pages.
zone(1): 61440 pages.
zone(2): 0 pages.
Local APIC disabled by BIOS -- reenabling.
Found and enabled local APIC!
Kernel command line: vga=4 root=/dev/discs/disc0/part2 ro mem=262144K
Initializing CPU#0
Detected 670.105 MHz processor.
Console: colour VGA+ 80x30
Calibrating delay loop... 1336.93 BogoMIPS
Memory: 256344k/262144k available (782k kernel code, 5412k reserved, 242k data, 72k init, 0k highmem)
Dentry-cache hash table entries: 32768 (order: 6, 262144 bytes)
Inode-cache hash table entries: 16384 (order: 5, 131072 bytes)
Mount-cache hash table entries: 4096 (order: 3, 32768 bytes)
Buffer-cache hash table entries: 16384 (order: 4, 65536 bytes)
Page-cache hash table entries: 65536 (order: 6, 262144 bytes)
CPU: Before vendor init, caps: 0383fbff 00000000 00000000, vendor = 0
CPU: L1 I cache: 16K, L1 D cache: 16K
CPU: L2 cache: 256K
Intel machine check architecture supported.
Intel machine check reporting enabled on CPU#0.
CPU: After vendor init, caps: 0383fbff 00000000 00000000 00000000
CPU:     After generic, caps: 0383fbff 00000000 00000000 00000000
CPU:             Common caps: 0383fbff 00000000 00000000 00000000
CPU: Intel Pentium III (Coppermine) stepping 01
Enabling fast FPU save and restore... done.
Enabling unmasked SIMD FPU exception support... done.
Checking 'hlt' instruction... OK.
POSIX conformance testing by UNIFIX
enabled ExtINT on CPU#0
ESR value before enabling vector: 00000040
ESR value after enabling vector: 00000000
Using local APIC timer interrupts.
calibrating APIC timer ...
..... CPU clock speed is 670.0819 MHz.
..... host bus clock speed is 103.0894 MHz.
cpu: 0, clocks: 1030894, slice: 515447
CPU0<T0:1030880,T1:515424,D:9,S:515447,C:1030894>
mtrr: v1.40 (20010327) Richard Gooch (rgooch@atnf.csiro.au)
mtrr: detected mtrr type: Intel
PCI: PCI BIOS revision 2.10 entry at 0xfb380, last bus=1
PCI: Using configuration type 1
PCI: Probing PCI hardware
Unknown bridge resource 0: assuming transparent
PCI: Using IRQ router PIIX [8086/7110] at 00:07.0
Limiting direct PCI/PCI transfers.
Linux NET4.0 for Linux 2.4
Based upon Swansea University Computer Society NET3.039
apm: BIOS version 1.2 Flags 0x07 (Driver version 1.15)
Starting kswapd
BIO: pool of 256 setup, 14Kb (56 bytes/bio)
biovec: init pool 0, 1 entries, 12 bytes
biovec: init pool 1, 4 entries, 48 bytes
biovec: init pool 2, 16 entries, 192 bytes
biovec: init pool 3, 64 entries, 768 bytes
biovec: init pool 4, 128 entries, 1536 bytes
biovec: init pool 5, 256 entries, 3072 bytes
devfs: v1.5 (20011204) Richard Gooch (rgooch@atnf.csiro.au)
devfs: devfs_debug: 0x0
devfs: boot_options: 0x1
block: 256 slots per queue, batch=32
Uniform Multi-Platform E-IDE driver Revision: 6.32
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
PIIX4: IDE controller on PCI slot 00:07.1
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later
    ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:pio, hdb:pio
    ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:pio, hdd:pio
HPT366: onboard version of chipset, pin1=1 pin2=2
HPT366: IDE controller on PCI slot 00:13.0
PCI: Found IRQ 11 for device 00:13.0
PCI: Sharing IRQ 11 with 00:13.1
HPT366: chipset revision 1
HPT366: not 100% native mode: will probe irqs later
    ide2: BM-DMA at 0xd400-0xd407, BIOS settings: hde:pio, hdf:pio
HPT366: IDE controller on PCI slot 00:13.1
PCI: Found IRQ 11 for device 00:13.1
PCI: Sharing IRQ 11 with 00:13.0
HPT366: chipset revision 1
HPT366: not 100% native mode: will probe irqs later
    ide3: BM-DMA at 0xe000-0xe007, BIOS settings: hdg:pio, hdh:pio
hdc: CRD-8240B, ATAPI CD/DVD-ROM drive
hde: ST310212A, ATA DISK drive
hdg: SAMSUNG SV0322A, ATA DISK drive
ide1 at 0x170-0x177,0x376 on irq 15
ide2 at 0xcc00-0xcc07,0xd002 on irq 11
ide3 at 0xd800-0xd807,0xdc02 on irq 11
blk: queue c023bc84, I/O limit 4095Mb (mask 0xffffffff)
hde: 20005650 sectors (10243 MB) w/512KiB Cache, CHS=19846/16/63, UDMA(66)
blk: queue c023c004, I/O limit 4095Mb (mask 0xffffffff)
hdg: 6250608 sectors (3200 MB) w/478KiB Cache, CHS=11024/9/63, UDMA(33)
Partition check:
 /dev/ide/host2/bus0/target0/lun0: [PTBL] [1245/255/63] p1 p2 p3 p4
 /dev/ide/host3/bus0/target0/lun0: p1
Linux agpgart interface v0.99 (c) Jeff Hartmann
agpgart: Maximum main memory to use for agp memory: 204M
agpgart: Detected Intel 440BX chipset
agpgart: AGP aperture is 256M @ 0xc0000000
NET4: Linux TCP/IP 1.0 for NET4.0
IP Protocols: ICMP, UDP, TCP, IGMP
IP: routing cache hash table of 2048 buckets, 16Kbytes
TCP: Hash tables configured (established 16384 bind 16384)
NET4: Unix domain sockets 1.0/SMP for Linux NET4.0.
VFS: Mounted root (ext2 filesystem) readonly.
Mounted devfs on /dev
Freeing unused kernel memory: 72k freed
Adding Swap: 80316k swap-space (priority -1)
Real Time Clock Driver v1.10e
es1370: version v0.37 time 16:25:02 Dec  8 2001
PCI: Found IRQ 9 for device 00:09.0
PCI: Sharing IRQ 9 with 00:07.2
es1370: found adapter at io 0xc400 irq 9
es1370: features: joystick off, line out, mic impedance 0
Serial driver version 5.05c (2001-07-08) with MANY_PORTS SHARE_IRQ SERIAL_PCI enabled
ttyS00 at 0x03f8 (irq = 4) is a 16550A
ttyS01 at 0x02f8 (irq = 3) is a 16550A
ne2k-pci.c:v1.02 10/19/2000 D. Becker/P. Gortmaker
  http://www.scyld.com/network/ne2k-pci.html
PCI: Found IRQ 10 for device 00:0d.0
eth0: RealTek RTL-8029 found at 0xc800, IRQ 10, 00:40:05:E4:DB:3F.
parport0: PC-style at 0x378, irq 7 [PCSPP,TRISTATE]
parport0: cpp_daisy: aa5500ff(98)
parport0: assign_addrs: aa5500ff(98)
parport0: Printer, HEWLETT-PACKARD DESKJET 930C
lp0: using parport0 (interrupt-driven).
lp0: compatibility mode
hdc: ATAPI CD-ROM drive, 0kB Cache, DMA
Uniform CD-ROM driver Revision: 3.12
hdc: ATAPI 24X CD-ROM drive, 128kB Cache, DMA

Re: 2.5.1-pre7 ide-cd module

[Jens Axboe]

On Sat, Dec 08 2001, Pierre Rousselet wrote:
> Attached is dmesg with 2.5.1-pre7 + devfs-patch-v203.
> 
> The first and second manual loading of the ide-cd module give something
> different.
> 
> #modprobe ide-cd ; rmmod ide-cd ; modprobe ide-cd
> 
> hdc: ATAPI CD-ROM drive, 0kB Cache, DMA
> Uniform CD-ROM driver Revision: 3.12
> hdc: ATAPI 24X CD-ROM drive, 128kB Cache, DMA

Upon first load, could you cat /proc/sys/dev/cdrom/info? It would appear
that the drive is sending zeroed data but not reporting a failure.

Is this a new problem?

-- 
Jens Axboe

Re: 2.5.1-pre7 ide-cd module

[Pierre Rousselet]

Jens Axboe wrote:
> 
> On Sat, Dec 08 2001, Pierre Rousselet wrote:
> > Attached is dmesg with 2.5.1-pre7 + devfs-patch-v203.
> >
> > The first and second manual loading of the ide-cd module give something
> > different.
> >
> > #modprobe ide-cd ; rmmod ide-cd ; modprobe ide-cd
> >
> > hdc: ATAPI CD-ROM drive, 0kB Cache, DMA
> > Uniform CD-ROM driver Revision: 3.12
> > hdc: ATAPI 24X CD-ROM drive, 128kB Cache, DMA
> 
> Upon first load, could you cat /proc/sys/dev/cdrom/info? It would appear
> that the drive is sending zeroed data but not reporting a failure.

First load :
CD-ROM information, Id: cdrom.c 3.12 2000/10/18

drive name:             hdc
drive speed:            0
drive # of slots:       1
Can close tray:         0
Can open tray:          1
Can lock tray:          1
Can change speed:       1
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         0
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           0
Can write DVD-R:        0
Can write DVD-RAM:      0

Second load :
CD-ROM information, Id: cdrom.c 3.12 2000/10/18

drive name:             hdc
drive speed:            1
drive # of slots:       1
Can close tray:         1
Can open tray:          1
Can lock tray:          1
Can change speed:       1
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         1
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           0
Can write DVD-R:        0
Can write DVD-RAM:      0

> Is this a new problem?

The same is in 2.5.1-pre5 (i reported the 'Can play audio : 0' to l-k).

Pierre
-- 
------------------------------------------------
 Pierre Rousselet <pierre.rousselet@wanadoo.fr>
------------------------------------------------

Re: 2.5.1-pre7 ide-cd module

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

On Sat, Dec 08 2001, Pierre Rousselet wrote:
> > Is this a new problem?
> 
> The same is in 2.5.1-pre5 (i reported the 'Can play audio : 0' to l-k).

How about 2.4.16? Try attached patch.

-- 
Jens Axboe


[-- Attachment #2: ide-cd-cap --]
[-- Type: text/plain, Size: 553 bytes --]

--- /opt/kernel/linux-2.5.1-pre7/drivers/ide/ide-cd.c	Fri Dec  7 20:38:44 2001
+++ drivers/ide/ide-cd.c	Sat Dec  8 11:42:47 2001
@@ -2527,8 +2527,10 @@
 	 * page capabilities size, but older drives break.
 	 */
 	if (drive->id) {
-		if (!(!strcmp(drive->id->model, "ATAPI CD ROM DRIVE 50X MAX") ||
-		    !strcmp(drive->id->model, "WPI CDS-32X")))
+		if (!(!strcmp(drive->id->model, "ATAPI CD ROM DRIVE 50X MAX")
+		    || !strcmp(drive->id->model, "WPI CDS-32X"))
+		    || !strcmp(drive->id->model, "CRD-8240B"))
+
 			size -= sizeof(cap->pad);
 	}
 

Re: 2.5.1-pre7 ide-cd module

[Pierre Rousselet]

Jens Axboe wrote:
> 
> On Sat, Dec 08 2001, Pierre Rousselet wrote:
> > > Is this a new problem?
> >
> > The same is in 2.5.1-pre5 (i reported the 'Can play audio : 0' to l-k).
> 
> How about 2.4.16? Try attached patch.

2.4.16 to 2.4.17-pre6 are quite good. I'll try the patch right now.

Pierre
-- 
------------------------------------------------
 Pierre Rousselet <pierre.rousselet@wanadoo.fr>
------------------------------------------------

Re: 2.5.1-pre7 ide-cd module

[Jens Axboe]

On Sat, Dec 08 2001, Pierre Rousselet wrote:
> Jens Axboe wrote:
> > 
> > On Sat, Dec 08 2001, Pierre Rousselet wrote:
> > > > Is this a new problem?
> > >
> > > The same is in 2.5.1-pre5 (i reported the 'Can play audio : 0' to l-k).
> > 
> > How about 2.4.16? Try attached patch.
> 
> 2.4.16 to 2.4.17-pre6 are quite good. I'll try the patch right now.

Ah ok, that's interesting. Hmm, will add to bio todo list.

-- 
Jens Axboe

Re: 2.5.1-pre7 ide-cd module

[Pierre Rousselet]

Jens Axboe wrote:
> 
> On Sat, Dec 08 2001, Pierre Rousselet wrote:
> > > Is this a new problem?
> >
> > The same is in 2.5.1-pre5 (i reported the 'Can play audio : 0' to l-k).
> 
> How about 2.4.16? Try attached patch.

With your patch applied on ide-cd.c (i double-checked it is applied):
#modprobe ide-cd ; cat /proc/sys/dev/cdrom/info
CD-ROM information, Id: cdrom.c 3.12 2000/10/18

drive name:             hdc
drive speed:            0
drive # of slots:       1
Can close tray:         0
Can open tray:          1
Can lock tray:          1
Can change speed:       1
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         0
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           0
Can write DVD-R:        0
Can write DVD-RAM:      0
#rmmod ide-cd ; modprobe ide-cd ; cat /proc/sys/dev/cdrom/info
CD-ROM information, Id: cdrom.c 3.12 2000/10/18

drive name:             hdc
drive speed:            1
drive # of slots:       1
Can close tray:         1
Can open tray:          1
Can lock tray:          1
Can change speed:       1
Can select disk:        0
Can read multisession:  1
Can read MCN:           1
Reports media changed:  1
Can play audio:         1
Can write CD-R:         0
Can write CD-RW:        0
Can read DVD:           0
Can write DVD-R:        0
Can write DVD-RAM:      0



-- 
------------------------------------------------
 Pierre Rousselet <pierre.rousselet@wanadoo.fr>
------------------------------------------------

Re: 2.5.1-pre7 ide-cd module

[Udo A. Steinberg]

Jens Axboe wrote:
> 
> Upon first load, could you cat /proc/sys/dev/cdrom/info? It would appear
> that the drive is sending zeroed data but not reporting a failure.
> 
> Is this a new problem?

Same problem here (2.5.1-pre), but the code is monolithic and not a module.

hde: ATAPI CD-ROM drive, 0kB Cache, DMA
                         ^^^^^^^^^
It used to work correctly before, which rules out a bad drive. Do you want
me to check which kernel broke it first?

Regards,
Udo.

Re: 2.5.1-pre7 ide-cd module

[Jens Axboe]

On Sat, Dec 08 2001, Udo A. Steinberg wrote:
> Jens Axboe wrote:
> > 
> > Upon first load, could you cat /proc/sys/dev/cdrom/info? It would appear
> > that the drive is sending zeroed data but not reporting a failure.
> > 
> > Is this a new problem?
> 
> Same problem here (2.5.1-pre), but the code is monolithic and not a module.
> 
> hde: ATAPI CD-ROM drive, 0kB Cache, DMA
>                          ^^^^^^^^^
> It used to work correctly before, which rules out a bad drive. Do you want
> me to check which kernel broke it first?

Yes please -- try 2.5.1-pre1 and 2.5.1-pre2, it probably broke there.

-- 
Jens Axboe

Re: 2.5.1-pre7 ide-cd module

[Udo A. Steinberg]

Jens Axboe wrote:
> 
> Yes please -- try 2.5.1-pre1 and 2.5.1-pre2, it probably broke there.

Indeed. pre1 works, pre2 doesn't:

pre1:
hda: IBM-DTLA-307030, ATA DISK drive
hdb: IBM-DTLA-307030, ATA DISK drive
hde: PLEXTOR CD-R PX-W1210A, ATAPI CD/DVD-ROM drive
ide0 at 0x9400-0x9407,0x9002 on irq 10
ide2 at 0x1f0-0x1f7,0x3f6 on irq 14
hda: 60036480 sectors (30739 MB) w/1916KiB Cache, CHS=59560/16/63, UDMA(100)
hdb: 60036480 sectors (30739 MB) w/1916KiB Cache, CHS=59560/16/63, UDMA(100)
hde: ATAPI 32X CD-ROM CD-R/RW drive, 2048kB Cache, DMA

pre2:
hda: IBM-DTLA-307030, ATA DISK drive
hdb: IBM-DTLA-307030, ATA DISK drive
hde: PLEXTOR CD-R PX-W1210A, ATAPI CD/DVD-ROM drive
ide0 at 0x9400-0x9407,0x9002 on irq 10
ide2 at 0x1f0-0x1f7,0x3f6 on irq 14
blk: queue c0345804, I/O limit 4095Mb (mask 0xffffffff)
hda: 60036480 sectors (30739 MB) w/1916KiB Cache, CHS=59560/16/63, UDMA(100)
blk: queue c0345974, I/O limit 4095Mb (mask 0xffffffff)
hdb: 60036480 sectors (30739 MB) w/1916KiB Cache, CHS=59560/16/63, UDMA(100)
hde: ATAPI CD-ROM drive, 0kB Cache, DMA

Regards,
Udo.

Re: 2.5.1-pre7 ide-cd module

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Sat, Dec 08 2001, Udo A. Steinberg wrote:
> Jens Axboe wrote:
> > 
> > Yes please -- try 2.5.1-pre1 and 2.5.1-pre2, it probably broke there.
> 
> Indeed. pre1 works, pre2 doesn't:

Ah, I think I see the problem. Very first mode page capabilities probe
fails, which is expected and therefore retried. But now we've killed the
correct length of command, which should only be done on success. The
second time you load ide-cd, it succeeds on first probe and thus works.

Attached patch should fix it.

-- 
Jens Axboe


[-- Attachment #2: ide-cd-stat --]
[-- Type: text/plain, Size: 359 bytes --]

--- /opt/kernel/linux-2.5.1-pre7/drivers/ide/ide-cd.c	Fri Dec  7 20:38:44 2001
+++ drivers/ide/ide-cd.c	Sat Dec  8 14:39:43 2001
@@ -2145,7 +2145,8 @@
 	pc.timeout = cgc->timeout;
 	pc.sense = cgc->sense;
 	cgc->stat = cdrom_queue_packet_command(drive, &pc);
-	cgc->buflen -= pc.buflen;
+	if (!cgc->stat)
+		cgc->buflen -= pc.buflen;
 	return cgc->stat;
 }
 

Re: 2.5.1-pre7 ide-cd module

[Udo A. Steinberg]

Jens Axboe wrote:
> 
> Attached patch should fix it.

Confirmed; that makes it work again. Thanks.

Regards,
Udo.