From: Pavel Machek <pavel@suse.cz>
To: Alexander Viro <viro@math.psu.edu>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for idiocy in mount_root cleanups.
Date: Sun, 9 Dec 2001 23:56:22 +0100 [thread overview]
Message-ID: <20011209235621.C117@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.33.0112080957530.16918-100000@athlon.transmeta.com> <Pine.GSO.4.21.0112081604060.7302-100000@binet.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0112081604060.7302-100000@binet.math.psu.edu>
Hi!
> OK, for the time being we can simply go with
>
> diff -urN C1-pre7/init/do_mounts.c C1-pre7-fix/init/do_mounts.c
> --- C1-pre7/init/do_mounts.c Fri Dec 7 20:48:43 2001
> +++ C1-pre7-fix/init/do_mounts.c Sat Dec 8 15:54:46 2001
> @@ -351,7 +351,8 @@
> mount("devfs", ".", "devfs", 0, NULL);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> retry:
> for (p = fs_names; *p; p += strlen(p)+1) {
> - err = mount(name,"/root",p,root_mountflags,root_mount_data);
> + int err;
> + err = sys_mount(name,"/root",p,root_mountflags,root_mount_data);
> switch (err) {
> case 0:
> goto done;
>
> Is that OK with you?
Why do you *need* to declare err, when you did not need it before?
[Calling sys_mount is indeed right way to do this. Ouch, and look 4
lines above that. Do I see "mount()" without checking error return?]
Pavel
--
"I do not steal MS software. It is not worth it."
-- Pavel Kankovsky
next prev parent reply other threads:[~2001-12-10 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-08 11:40 [PATCH] fix for idiocy in mount_root cleanups Alexander Viro
2001-12-08 18:00 ` Linus Torvalds
2001-12-08 20:42 ` Alexander Viro
2001-12-08 21:04 ` Alexander Viro
2001-12-09 22:56 ` Pavel Machek [this message]
2001-12-10 11:36 ` Alexander Viro
2001-12-09 22:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011209235621.C117@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox